Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Unified Diff: rietveld/views.py

Issue 776: Allow reviewers to change the reviewers list (Closed) SVN Base: http://rietveld.googlecode.com/svn/trunk/
Patch Set: Created 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side by-side-diff with in-line comments
Download patch
« no previous file | templates/publish.html » ('j') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Index: rietveld/views.py
===================================================================
--- rietveld/views.py (revision 79)
+++ rietveld/views.py (working copy)
@@ -187,6 +187,9 @@
class MiniPublishForm(forms.Form):
send_mail = forms.BooleanField()
+ reviewers = forms.CharField(required=False,
+ max_length=1000,
+ widget=forms.TextInput(attrs={'size': 60}))
message = forms.CharField(required=False,
max_length=10000,
widget=forms.Textarea(attrs={'cols': 60}))
@@ -959,6 +962,7 @@
issue.subject = subject
issue.reviewers = reviewers
else:
+ issue.reviewers = reviewers
GvR 2008/05/10 15:44:24 I'd move this one line downfor symmetry with the '
jiayao 2008/05/11 11:33:27 On 2008/05/10 15:44:24, GvR wrote: > I'd move this
subject = issue.subject
tbd.append(issue) # To update the last modified time
message = form.cleaned_data['message'].replace('\r\n', '\n')
@@ -1243,3 +1247,4 @@
if not form.is_valid():
return respond(request, 'settings.html', {'form': form})
return HttpResponseRedirect('/settings')
+
GvR 2008/05/10 15:44:24 Don't add an extra blank line at the end.
jiayao 2008/05/11 11:33:27 On 2008/05/10 15:44:24, GvR wrote: > Don't add an
« no previous file | templates/publish.html » ('j')

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r338