Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 7678047: Issue 2924: Doc: \startMeasureCount and \stopMeasureCount needs documenting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by david.nalesnik
Modified:
11 years, 1 month ago
Reviewers:
Graham Percival, janek, phileholmes
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Issue 2924: Doc: \startMeasureCount and \stopMeasureCount needs documenting The following patch is a preliminary step towards documenting the Measure_counter_engraver added in version 2.17.7. The patch consists of two snippets, the first illustrating basic usage, and the second demonstrating a workaround for creating centered bar numbers.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -0 lines) Patch
A Documentation/snippets/centered-measure-numbers.ly View 1 chunk +56 lines, -0 lines 0 comments Download
M Documentation/snippets/contexts-and-engravers.snippet-list View 2 chunks +2 lines, -0 lines 0 comments Download
M Documentation/snippets/editorial-annotations.snippet-list View 1 chunk +1 line, -0 lines 0 comments Download
A Documentation/snippets/new/centered-measure-numbers.ly View 1 chunk +48 lines, -0 lines 0 comments Download
A Documentation/snippets/new/numbering-groups-of-measures.ly View 1 chunk +53 lines, -0 lines 0 comments Download
A Documentation/snippets/numbering-groups-of-measures.ly View 1 chunk +61 lines, -0 lines 0 comments Download
M Documentation/snippets/repeats.snippet-list View 1 chunk +2 lines, -0 lines 0 comments Download
M Documentation/snippets/staff-notation.snippet-list View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
david.nalesnik
Please review. Thanks! David
11 years, 1 month ago (2013-03-17 02:14:28 UTC) #1
PhilEHolmes
I've not tested the snippets, but otherwise the patch LGTM. I'm assuming the only files ...
11 years, 1 month ago (2013-03-17 10:35:40 UTC) #2
david.nalesnik
On 2013/03/17 10:35:40, PhilEHolmes wrote: > I've not tested the snippets, but otherwise the patch ...
11 years, 1 month ago (2013-03-17 11:25:43 UTC) #3
janek
LGTM
11 years, 1 month ago (2013-03-17 16:41:11 UTC) #4
Graham Percival
LGTM
11 years, 1 month ago (2013-03-21 03:14:51 UTC) #5
david.nalesnik
11 years, 1 month ago (2013-03-23 12:54:24 UTC) #6
Thank you all for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b