Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4229)

Issue 7644: * Figured Bass: Break extender line if we have a different augmentation/diminished (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by Reinhold
Modified:
14 years, 8 months ago
Reviewers:
Neil Puttock, hanwenn
Visibility:
Public.

Description

So far, an extender line was only broken when a figure had a different alteration (+,-,!), but not if it had a different augmentation (\\, \+ or /). This patch also stores the state of the other modifiers and breaks the extender if they change.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
A input/regression/figured-bass-continuation-modifiers.ly View 1 chunk +21 lines, -0 lines 0 comments Download
M lily/figured-bass-engraver.cc View 5 chunks +19 lines, -1 line 1 comment Download

Messages

Total messages: 2
hanwenn
LGTM - you might even want to see if you can fold repetitive code using ...
15 years, 6 months ago (2008-10-22 00:10:10 UTC) #1
Neil Puttock
15 years, 6 months ago (2008-10-22 20:48:15 UTC) #2
http://codereview.appspot.com/7644/diff/1/3
File lily/figured-bass-engraver.cc (right):

http://codereview.appspot.com/7644/diff/1/3#newcode105
Line 105: scm_gc_mark (groups_[i].alteration_);
Mark augmented_, diminished_ and augmented_slash_ too?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b