Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(476)

Issue 7638043: Make reference pitch for \relative non-optional (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dak
Modified:
11 years, 1 month ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make reference pitch for \relative non-optional Using \relative without reference pitch has been deprecated for a long time, so this change brings LilyPond's codebase (and files converted using convert-ly) into conformance with recommended practices. Obviously contains commit Run scripts/auxiliar/update-with-convert-ly.sh

Patch Set 1 #

Patch Set 2 : Finetune conversion rules to get \relative c' or \relative do' in unambiguous cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -93 lines) Patch
M Documentation/fr/notation/rhythms.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/input.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/displaying-a-whole-grandstaff-system-if-only-one-of-its-staves-is-alive.ly View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/unfretted-headword.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/accidental-collision.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/accidental-piano.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/alignment-order.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/bar-line-define-bar-glyph.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/bar-line-define-bar-line.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/bar-line-segno.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/bar-lines.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/beam-collision-basic.ly View 5 chunks +6 lines, -6 lines 0 comments Download
M input/regression/beam-collision-beamcount.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/beam-collision-prefatory-matter.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/collision-alignment.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/figured-bass-continuation.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/figured-bass-continuation-center.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/figured-bass-continuation-modifiers.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/grace-slashed-no-slur.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/instrument-switch.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/instrument-switch-invalid-warning.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/keys.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/line-dashed-period.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/lyric-combine-switch-voice.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/lyric-combine-switch-voice-2.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/music-function-end-spanners.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/no-staff.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/optional-args.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/repeat-percent-grace.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/rest-collision-beam-note.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/script-stack-horizontal.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/set-once.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/skip-of-length.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/slur-dynamics.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/slur-script.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/song-reordering.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-reordering2.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-slurs.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/system-start-heavy-bar.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/system-start-nesting.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/tablature-slide.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/tie-whole.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/trill-spanner-grace.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M python/convertrules.py View 1 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2
dak
Finetune conversion rules to get \relative c' or \relative do' in unambiguous cases
11 years, 1 month ago (2013-03-09 13:53:04 UTC) #1
janek
11 years, 1 month ago (2013-03-12 22:25:42 UTC) #2
LGTM.

I think it would be clearer if the descrption focused more on this change, and a
bit less on explaining context of \relative discussions.

In other words, the sentence "This is intended as a potential migration strategy
to issue 3229 where
leaving off the optional reference pitch leads to a different default." is quite
difficult to understand imo.

cheers,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b