Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 7578046: Script for running pixel-based regtest comparisons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by PhilEHolmes
Modified:
11 years ago
Reviewers:
janek, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

I think this is reasonably self explanatory. Running the script with -o -j9 will create a set of "old" images in build/out-png-check. Make changes to lily, compile and run the script -n -jX and you'll be told which images are different, and a set of image differences will be in regtest-diffs. Please review. I'm aware that this will require updates to the CG, but think those should come after this is accepted.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
A scripts/auxiliar/NoTagline.ly View 1 chunk +4 lines, -0 lines 0 comments Download
A scripts/auxiliar/make-regtest-pngs.sh View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 3
PhilEHolmes
Please review.
11 years, 1 month ago (2013-03-16 16:51:31 UTC) #1
lemzwerg
LGTM. My only (very minor) concern are overlong lines in the script, something which I ...
11 years, 1 month ago (2013-03-16 19:24:34 UTC) #2
janek
11 years, 1 month ago (2013-03-17 16:34:00 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b