Eliminates side poisition calculations for system-start-text grobs.

Eliminates side poisition calculations for system-start-text grobs.

The spacing of system-star-text-interface implementing grobs used side
positioning against an support element list of zero, which just
shifted them to the left by their width. Instead of using the
side-position-interface with this (which required a special case
for these grobs that is now deleted), we use their X-offset function.

Also, we change the name of the list of elements used for alignment,
as elements should only be used for axis groups.

[janek, 2013-03-18 08:18:10]

Whoah, Mike!  I've understood your patch in first reading! Nice commit message.

> The spacing of system-star-text-interface implementing grobs used side

typo (system-start-text)

> Also, we change the name of the list of elements used for alignment,
> as elements should only be used for axis groups.

maybe enclose "elements" (from the second line) in quotes?  From what i
understand, this sentence says that 'elements' is a special identifier that
should only be used for axis groups.

anyway, LGTM :)

thanks!
Janek

[Keith, 2013-03-19 06:53:03]

This will be nice.
Notice that the Stanza number in 'input/regression/hara-kiri-stanza-number.ly'
lost its alignment.

https://codereview.appspot.com/7574048/diff/1/scm/define-grob-interfaces.scm
File scm/define-grob-interfaces.scm (right):

https://codereview.appspot.com/7574048/diff/1/scm/define-grob-interfaces.scm#...
scm/define-grob-interfaces.scm:251: "A stanza number, to be put in from of a
lyrics line."
Needs something.

[MikeSol, 2013-03-24 07:11:39]

Fixes StanzaNumber positioning

[dak, 2013-03-24 12:59:36]

https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
File input/regression/instrument-name-x-align.ly (right):

https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
input/regression/instrument-name-x-align.ly:33: \set Staff . instrumentName =
\markup \right-column {
Make no mistake: the previous code looked suspiciously asymmetric.  Is your
change a cosmetic one, or is it related to other strange behaviors like the
\left-column/\column mismatch we had noticed elsewhere?

[mike7, 2013-03-24 19:06:49]

On 24 mars 2013, at 14:59, dak@gnu.org wrote:

> 
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
> File input/regression/instrument-name-x-align.ly (right):
> 
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
> input/regression/instrument-name-x-align.ly:33: \set Staff .
> instrumentName = \markup \right-column {
> Make no mistake: the previous code looked suspiciously asymmetric.  Is
> your change a cosmetic one, or is it related to other strange behaviors
> like the \left-column/\column mismatch we had noticed elsewhere?
> 
> https://codereview.appspot.com/7574048/

The latter - I noticed it clashed and have run into problems with right column
in the past and decided to get rid of it.
I can put it in a different commit before pushing this one.

Cheers,
MS

[dak, 2013-03-24 19:59:38]

On 2013/03/24 19:06:49, mike7 wrote:
> On 24 mars 2013, at 14:59, mailto:dak@gnu.org wrote:
> 
> > 
> >
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
> > File input/regression/instrument-name-x-align.ly (right):
> > 
> >
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
> > input/regression/instrument-name-x-align.ly:33: \set Staff .
> > instrumentName = \markup \right-column {
> > Make no mistake: the previous code looked suspiciously asymmetric.  Is
> > your change a cosmetic one, or is it related to other strange behaviors
> > like the \left-column/\column mismatch we had noticed elsewhere?
> > 
> > https://codereview.appspot.com/7574048/
> 
> The latter - I noticed it clashed and have run into problems with right column
> in the past and decided to get rid of it.
> I can put it in a different commit before pushing this one.

In general, separate issues should be separate commits even if you don't want to
start a tracker issue of its own for it.

Since one wants to be able to pinpoint stuff by bisection, the regtest change
should be in a commit before the rest.

[MikeSol, 2013-03-28 19:00:17]

On 2013/03/24 19:59:38, dak wrote:
> On 2013/03/24 19:06:49, mike7 wrote:
> > On 24 mars 2013, at 14:59, mailto:dak@gnu.org wrote:
> > 
> > > 
> > >
> >
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
> > > File input/regression/instrument-name-x-align.ly (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-...
> > > input/regression/instrument-name-x-align.ly:33: \set Staff .
> > > instrumentName = \markup \right-column {
> > > Make no mistake: the previous code looked suspiciously asymmetric.  Is
> > > your change a cosmetic one, or is it related to other strange behaviors
> > > like the \left-column/\column mismatch we had noticed elsewhere?
> > > 
> > > https://codereview.appspot.com/7574048/
> > 
> > The latter - I noticed it clashed and have run into problems with right
column
> > in the past and decided to get rid of it.
> > I can put it in a different commit before pushing this one.
> 
> In general, separate issues should be separate commits even if you don't want
to
> start a tracker issue of its own for it.
> 
> Since one wants to be able to pinpoint stuff by bisection, the regtest change
> should be in a commit before the rest.

Will do - I'll push this as two separate commits.

Cheers,
MS