Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(836)

Issue 756041: Changed light_side policy and added albedo functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by aconty
Modified:
13 years, 3 months ago
Reviewers:
larrygritz, osl-dev, ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Now get_light_side returns the actual light side of the closure regardless of the singularity. And I have added albedo functions to all the bsdf's to make sampling easier and better. Note that those albedo functions don't have to be accurate. Although they are in the same review, both things will be checked in as separated commits.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -5 lines) Patch
src/include/oslclosure.h View 1 1 chunk +21 lines, -0 lines 1 comment Download
src/liboslexec/bsdf_ashikhmin_velvet.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_cloth.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_cloth_specular.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_diffuse.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_fakefur.cpp View 3 chunks +16 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_hair.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_microfacet.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_phong.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_reflection.cpp View 4 chunks +13 lines, -2 lines 0 comments Download
src/liboslexec/bsdf_refraction.cpp View 4 chunks +13 lines, -2 lines 0 comments Download
src/liboslexec/bsdf_transparent.cpp View 1 chunk +6 lines, -1 line 0 comments Download
src/liboslexec/bsdf_ward.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
src/liboslexec/bsdf_westin.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
src/liboslexec/closure_test.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
aconty
14 years, 1 month ago (2010-03-25 18:50:51 UTC) #1
larrygritz
http://codereview.appspot.com/756041/diff/1/2 File src/include/oslclosure.h (right): http://codereview.appspot.com/756041/diff/1/2#newcode258 src/include/oslclosure.h:258: /// be used for sampling decissions decisions. Can you ...
14 years, 1 month ago (2010-03-25 22:54:55 UTC) #2
aconty
Addressed comments
14 years, 1 month ago (2010-03-25 23:30:48 UTC) #3
larrygritz
thanks, that's much more clear now
14 years, 1 month ago (2010-03-25 23:36:22 UTC) #4
ckulla
LGTM2 http://codereview.appspot.com/756041/diff/15001/16001 File src/include/oslclosure.h (right): http://codereview.appspot.com/756041/diff/15001/16001#newcode257 src/include/oslclosure.h:257: /// be less or equal than 1.0 and ...
14 years, 1 month ago (2010-03-26 16:57:12 UTC) #5
aconty
14 years, 1 month ago (2010-03-26 17:43:38 UTC) #6
> guaranteed to be accurate.
> "less than or equal to 1.0"

Thanks, fixed that. Will commit when the render part gets approved
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b