Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1621)

Issue 7518047: Make \relative { ... } interpret the first pitch as an absolute one (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dak
Modified:
8 years, 9 months ago
Reviewers:
janek, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make \relative { ... } interpret the first pitch as an absolute one The previous default of \relative { ... } being \relative c' { ... } made c' more special than warranted. Having to write \relative f { ... } for this functionality seems awkward since f serves no musical function but just happens to be the middle of the scale. Iff the scale is the standard scale. The new definition of \relative takes care to determine the "middle of the scale" reference point properly even in the case of non-standard scales. Also contains Document \relative { ... } behavior And it is currently rebased on the code for issue 3231 to make it testable. Once issue 3231 passes into master, this patch will get reduced in size.

Patch Set 1 #

Patch Set 2 : Factor \absolute in documentation, be more explicit #

Patch Set 3 : Make examples fit whole bars #

Total comments: 3

Patch Set 4 : Address Trevor's comments #

Patch Set 5 : Changes entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -15 lines) Patch
M Documentation/changes.tely View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M Documentation/learning/common-notation.itely View 1 2 3 3 chunks +25 lines, -10 lines 0 comments Download
M Documentation/notation/pitches.itely View 1 2 3 1 chunk +21 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 7
janek
LGTM
11 years, 1 month ago (2013-03-17 15:59:29 UTC) #1
dak
Factor \absolute in documentation, be more explicit
11 years, 1 month ago (2013-03-29 08:24:17 UTC) #2
dak
Make examples fit whole bars
11 years, 1 month ago (2013-03-29 09:00:41 UTC) #3
Trevor Daniels
https://codereview.appspot.com/7518047/diff/4004/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/7518047/diff/4004/Documentation/learning/common-notation.itely#newcode1330 Documentation/learning/common-notation.itely:1330: using @code{\relative}, pitches are interpreted in absolute mode. "Without ...
11 years, 1 month ago (2013-03-29 10:26:01 UTC) #4
dak
Address Trevor's comments
11 years, 1 month ago (2013-03-29 19:21:51 UTC) #5
Trevor Daniels
I'm happy with these changes. Thanks David. LGTM. Trevor
11 years, 1 month ago (2013-03-29 21:10:49 UTC) #6
dak
11 years, 1 month ago (2013-03-30 09:50:26 UTC) #7
Changes entries
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b