FSA Add WindowsAclFileAttributeViewsTest (Part 1)

This adds WindowsAclFileAttributeViewsTest that only tests
the newAclEntry() method.

[pjo, 2014-03-13 06:09:28]

Thank you.

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViews.java
(right):

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViews.java:391:
Account getAccountBySid(WinNT.PSID sid) throws Win32Exception {
make static?

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java (right):

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java:358: // a
notification buffer overflows which can cause some
editor removing whitespace?

https://codereview.appspot.com/75170044/diff/1/test/com/google/enterprise/ada...
File test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java
(right):

https://codereview.appspot.com/75170044/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java:65:
.setSid(new AccountSid(SID_NAME_USE.SidTypeUnknown, "", "")).build();
indent

https://codereview.appspot.com/75170044/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java:93:
testNewAclEntryGroupPrincipal(AccountSid.group("groupName", null), "groupName");
over80

[Brett, 2014-03-13 16:23:38]

PJ's feedback

[Brett, 2014-03-13 16:24:05]

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViews.java
(right):

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViews.java:391:
Account getAccountBySid(WinNT.PSID sid) throws Win32Exception {
On 2014/03/13 06:09:28, pjo wrote:
> make static?

I can't override static methods.

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java (right):

https://codereview.appspot.com/75170044/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java:358: // a
notification buffer overflows which can cause some
On 2014/03/13 06:09:28, pjo wrote:
> editor removing whitespace?

Fixed (again?)

https://codereview.appspot.com/75170044/diff/1/test/com/google/enterprise/ada...
File test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java
(right):

https://codereview.appspot.com/75170044/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java:65:
.setSid(new AccountSid(SID_NAME_USE.SidTypeUnknown, "", "")).build();
On 2014/03/13 06:09:28, pjo wrote:
> indent

Done.

https://codereview.appspot.com/75170044/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java:93:
testNewAclEntryGroupPrincipal(AccountSid.group("groupName", null), "groupName");
On 2014/03/13 06:09:28, pjo wrote:
> over80

Done.

[pjo, 2014-03-13 16:34:15]

Thank you.  LGTM.

https://codereview.appspot.com/75170044/diff/20001/test/com/google/enterprise...
File test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java
(right):

https://codereview.appspot.com/75170044/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java:301:
throw new Win32Exception(WinError.ERROR_NONE_MAPPED);
check for null in ctor instead?

[Brett, 2014-03-13 18:44:16]

Committed 13 March 2014 to File System Adaptor:
To https://code.google.com/p/plexi.fs/
   d73320b..93a8248  master -> master

https://codereview.appspot.com/75170044/diff/20001/test/com/google/enterprise...
File test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java
(right):

https://codereview.appspot.com/75170044/diff/20001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/fs/WindowsAclFileAttributeViewsTest.java:301:
throw new Win32Exception(WinError.ERROR_NONE_MAPPED);
On 2014/03/13 16:34:16, pjo wrote:
> check for null in ctor instead?

No.  This code path is used by the test for unresolvable SID.
Lookup of an unresolvable SID throws ERROR_NONE_MAPPED.