Issue 75050: Fix for issue 18 on code.google.com issues list

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75050: Fix for issue 18 on code.google.com issues list

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years ago by valkar207

Modified:
11 years, 6 months ago

Reviewers:
Alex

CC:
testability-explorer-dev_googlegroups.com

Base URL:
http://testability-explorer.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 17 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -8 lines)			Patch
M	core/src/main/java/com/google/test/metric/MethodInfo.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	core/src/main/java/com/google/test/metric/Reason.java	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	core/src/main/java/com/google/test/metric/TestabilityVisitor.java	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	core/src/main/java/com/google/test/metric/report/SummaryGraphReport.java	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	core/src/test/java/com/google/test/metric/CostUtil.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/test/java/com/google/test/metric/MetricComputerTest.java	View	2 chunks	+33 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alex

16 years, 12 months ago (2009-06-16 17:06:27 UTC) #2

LGTM (the one change with casts to doubles)

next time, maybe if you make the patch from your IDE it will be easier to get
the right changeset into the review. You can manually create the issue on the
appspot site rather than with the script.

Expand All Messages | Collapse All Messages