Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 75049: Some extras with Reason.java

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years ago by valkar207
Modified:
11 years, 6 months ago
Reviewers:
Alex
CC:
testability-explorer-dev_googlegroups.com
Base URL:
http://testability-explorer.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixes for comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M core/src/main/java/com/google/test/metric/MethodInfo.java View 1 1 chunk +4 lines, -0 lines 0 comments Download
M core/src/main/java/com/google/test/metric/Reason.java View 1 1 chunk +7 lines, -1 line 0 comments Download
M core/src/main/java/com/google/test/metric/TestabilityVisitor.java View 1 2 chunks +13 lines, -1 line 0 comments Download
M core/src/test/java/com/google/test/metric/MetricComputerTest.java View 1 2 chunks +33 lines, -1 line 0 comments Download
M javascript/pom.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
valkar207
17 years ago (2009-06-12 17:35:04 UTC) #1
Alex
thanks, few comments: http://codereview.appspot.com/75049/diff/1/6 File core/src/main/java/com/google/test/metric/MethodInfo.java (right): http://codereview.appspot.com/75049/diff/1/6#newcode175 Line 175: public boolean getIsFinal() { should ...
16 years, 12 months ago (2009-06-16 17:03:38 UTC) #2
valkar207
16 years, 12 months ago (2009-06-17 16:34:25 UTC) #3
Alex
16 years, 12 months ago (2009-06-17 18:05:21 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b