Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(988)

Issue 75047: Support for installable libraries in numpy.distutils (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by cournape
Modified:
14 years, 3 months ago
Reviewers:
charlesr.harris
Base URL:
http://svn.scipy.org/svn/numpy/trunk/
Visibility:
Public.

Description

This adds a new command install_clib - The library is built as a conventional C library (by the build_clib command) - It does respect the --record and works to build egg (at least on my configuration). - info necessary to build/link against those installed C libraries are handled through simple .ini files, and are retrieved through a simple function call. - both numpy.distutils and numscons builds are supported Example of usage: see add_installed_library in numpy/core/setup.py. The npymath library can be reused as follows: from numpy.distutils.misc_util import get_info config.add_library('foo', sources=['foo.c'], extra_info=get_info('npymath'))

Patch Set 1 #

Patch Set 2 : Updated patch #

Patch Set 3 : V3 of the patch: more docs + fixes for relative install directories #

Unified diffs Side-by-side diffs Delta from patch set Stats (+919 lines, -33 lines) Patch
doc/source/reference/distutils.rst View 2 2 chunks +99 lines, -0 lines 0 comments Download
numpy/core/SConscript View 1 chunk +13 lines, -1 line 0 comments Download
numpy/core/mlib.ini.in View 1 chunk +12 lines, -0 lines 0 comments Download
numpy/core/npymath.ini.in View 1 chunk +19 lines, -0 lines 0 comments Download
numpy/core/setup.py View 1 2 3 chunks +25 lines, -3 lines 0 comments Download
numpy/core/setupscons.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
numpy/distutils/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
numpy/distutils/command/__init__.py View 2 chunks +2 lines, -1 line 0 comments Download
numpy/distutils/command/build_clib.py View 3 chunks +13 lines, -0 lines 0 comments Download
numpy/distutils/command/build_ext.py View 1 chunk +14 lines, -2 lines 0 comments Download
numpy/distutils/command/build_src.py View 3 chunks +68 lines, -1 line 0 comments Download
numpy/distutils/command/install.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
numpy/distutils/command/install_clib.py View 1 chunk +33 lines, -0 lines 0 comments Download
numpy/distutils/command/scons.py View 1 4 chunks +40 lines, -17 lines 0 comments Download
numpy/distutils/core.py View 2 chunks +3 lines, -1 line 0 comments Download
numpy/distutils/misc_util.py View 1 2 5 chunks +169 lines, -7 lines 0 comments Download
numpy/distutils/npy_pkg_config.py View 1 chunk +306 lines, -0 lines 0 comments Download
numpy/distutils/numpy_distribution.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
numpy/distutils/tests/test_npy_pkg_config.py View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 4
cournape
14 years, 9 months ago (2009-06-12 10:59:20 UTC) #1
cournape
Updated patch
14 years, 8 months ago (2009-07-08 11:27:33 UTC) #2
cournape
V3 of the patch: more docs + fixes for relative install directories
14 years, 8 months ago (2009-07-09 07:11:07 UTC) #3
charlesr.harris
14 years, 8 months ago (2009-07-13 05:33:41 UTC) #4
On 2009/07/09 07:11:07, cournape wrote:
> V3 of the patch: more docs + fixes for relative install directories

Hi David,

I just wrote a fairly long piece and then it disappeared. Argghhh. Anyway, the
upshot was that it might be useful for someone more familiar with distutils to
review the overall design, but that the patch was small enough that I don't
think you need to worry about merging it. If you are concerned about others
using it before the wrinkles are ironed out you could mark it experimental. No
doubt the next release of Scipy will be a good workout for the code.

Other than that, some meta-documentation would help build newbies like myself
get started, i.e., if I want to add a library and use it in another package,
what steps do I need to go through. Also, why did you do things the way you did,
what were the deficiencies of distutils that you needed to work around, and so
on. That information is sort of buried in comments along the way but it would be
helpful to bring it together in one place. As to the documentation of the
classes and functions, it looks a bit uneven. Some of it is complete but some of
it is also a bit on the terse side. Not that the current code is wonderfully
documented but we have to start somewhere ;)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b