Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5747)

Issue 7476043: Decouple \defaultchild from \accepts list in contexts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dak
Modified:
11 years ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Decouple \defaultchild from \accepts list in contexts The definition of a Bottom context previously was a context not accepting any subcontexts. Now it is a context without a \defaultchild. The defaultchild of a context previously was the first found in the \accepts list (if necessary, moving it there). While \defaultchild was tracked in context definitions, it was not explicit in instantiated contexts. Decoupling those makes for more flexible arrangements of contexts. For example, one might let Voice accept a SubVoice context without forcing SubVoice to be created when a Bottom context is called for when in Voice, simply by not giving Voice a \defaultchild.

Patch Set 1 #

Patch Set 2 : Fix the hardwired setup of Global #

Patch Set 3 : \defaultchild has to be first accept #

Patch Set 4 : Slight doc correction. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M lily/context.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M lily/context-def.cc View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M lily/global-context.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/context.hh View 1 chunk +1 line, -0 lines 0 comments Download
M ly/performer-init.ly View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dak
Fix the hardwired setup of Global
11 years, 1 month ago (2013-03-05 12:24:46 UTC) #1
dak
\defaultchild has to be first accept
11 years, 1 month ago (2013-03-05 14:17:05 UTC) #2
dak
11 years, 1 month ago (2013-03-05 15:33:45 UTC) #3
Slight doc correction.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b