Issue 7469: pass sys.path to subprocess PYTHONPATH

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7469: pass sys.path to subprocess PYTHONPATH (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 4 months ago by Tom

Modified:
16 years, 7 months ago

Reviewers:
Joe Hughes

CC:
googletransitdatafeed_googlegroups.com

Base URL:
http://googletransitdatafeed.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Setting PYTHONPATH of the process running the unittest code should also affect tests that run in a subprocess. The downside of this change is that the subprocess tests no longer check that everything will work by default once you've installed transitfeed. Hopefully if your tests are using a customized sys.path you know what you are doing.

Patch Set 1 #

Patch Set 2 : add comment per review feedback #

Created: 17 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	python/test/util.py	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Joe Hughes

17 years, 4 months ago (2008-10-14 01:03:42 UTC) #2

Looks good, thanks.

http://codereview.appspot.com/7469/diff/1/2
File python/test/util.py (right):

http://codereview.appspot.com/7469/diff/1/2#newcode95
Line 95: env = {"PYTHONPATH": ":".join(sys.path)}
Could you add a comment here similar to what you wrote in the change
description?

Expand All Messages | Collapse All Messages