Issue 744: [issue1736190] asyncore/asynchat patches

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 744: [issue1736190] asyncore/asynchat patches (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year, 7 months ago by GvR

Modified:
4 months ago

Reviewers:
report, josiah.carlson

CC:

SVN Base:
http://svn.python.org/view/*checkout*/python/trunk/

Visibility:
Public.

Description

http://bugs.python.org/issue1736190

This is now checked in.

Patch Set 1

Downloaded from: http://bugs.python.org/file10196/full_async_patch.patch

Created: 1 year, 7 months ago

Download raw patch set

Unified diffs	Side-by-side diffs	Stats			Patch
Doc/library/asynchat.rst	View	2 chunks	30 lines	0 comments	Download
Doc/library/asyncore.rst	View	1 chunk	26 lines	2 comments	Download
Lib/asynchat.py	View	3 chunks	190 lines	0 comments	Download
Lib/asyncore.py	View	15 chunks	321 lines	0 comments	Download
Lib/test/test_asyncore.py	View	1 chunk	14 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

GvR

(This is mostly a test of the bug/rietveld integration.) http://codereview.appspot.com/744/diff/1/22 File Doc/library/asyncore.rst (right): http://codereview.appspot.com/744/diff/1/22#newcode226 Line ...

1 year, 7 months ago

josiah.carlson

http://codereview.appspot.com/744/diff/1/22 File Doc/library/asyncore.rst (right): http://codereview.appspot.com/744/diff/1/22#newcode226 Line 226: A file_dispatcher takes a file descriptor or file ...

1 year, 6 months ago

http://codereview.appspot.com/744/diff/1/22
File Doc/library/asyncore.rst (right):

http://codereview.appspot.com/744/diff/1/22#newcode226
Line 226: A file_dispatcher takes a file descriptor or file object along with an
optional
On 2008/05/05 22:02:22, GvR wrote:
> Mind keeping the line length under 80 chars?

No problem.  Any other comments?

Expand All Messages | Collapse All Messages