Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1049)

Issue 74075: Upgrade to JUEL 2.1.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by awiner
Modified:
14 years, 9 months ago
Reviewers:
levik, louiscryan
CC:
shindig.remailer_gmail.com
Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -237 lines) Patch
M java/common/conf/shindig.properties View 1 chunk +1 line, -0 lines 0 comments Download
M java/common/pom.xml View 1 chunk +2 lines, -2 lines 0 comments Download
A java/common/src/main/java/org/apache/shindig/common/cache/NullCache.java View 1 chunk +44 lines, -0 lines 0 comments Download
M java/common/src/main/java/org/apache/shindig/expressions/Expressions.java View 5 chunks +43 lines, -105 lines 0 comments Download
A java/common/src/main/java/org/apache/shindig/expressions/ShindigTypeConverter.java View 1 chunk +174 lines, -0 lines 0 comments Download
M java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml View 2 chunks +9 lines, -1 line 0 comments Download
M java/common/src/test/java/org/apache/shindig/config/JsonContainerConfigTest.java View 7 chunks +8 lines, -8 lines 0 comments Download
M java/common/src/test/java/org/apache/shindig/expressions/ExpressionsTest.java View 3 chunks +102 lines, -1 line 2 comments Download
M java/common/src/test/java/org/apache/shindig/expressions/FunctionsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/common/src/test/java/org/apache/shindig/expressions/OpensocialFunctionsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/pom.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java View 4 chunks +9 lines, -87 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/GadgetELResolverTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelineExecutorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloaderTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/process/ProcessorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/render/DefaultServiceFetcherTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/PipelineDataGadgetRewriterTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/PipelinedDataTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/MessageELResolverTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/RenderTagHandlerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/XmlTemplateLibraryTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/server/pom.xml View 1 chunk +1 line, -1 line 0 comments Download
M java/social-api/pom.xml View 1 chunk +1 line, -1 line 0 comments Download
M java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java View 1 chunk +4 lines, -0 lines 0 comments Download
M java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/ActivityHandlerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M pom.xml View 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 3
awiner
Upgrade to JUEL 2.1.2 - Uses Ian Boston's temporary upload of JUEL 2.1.2 to a ...
14 years, 10 months ago (2009-06-17 21:26:44 UTC) #1
levik
http://codereview.appspot.com/74075/diff/1/8 File java/common/src/test/java/org/apache/shindig/expressions/ExpressionsTest.java (right): http://codereview.appspot.com/74075/diff/1/8#newcode174 Line 174: } What about the string "0"? What should ...
14 years, 10 months ago (2009-06-17 22:18:48 UTC) #2
awiner
14 years, 10 months ago (2009-06-17 23:29:55 UTC) #3
http://codereview.appspot.com/74075/diff/1/8
File
java/common/src/test/java/org/apache/shindig/expressions/ExpressionsTest.java
(right):

http://codereview.appspot.com/74075/diff/1/8#newcode174
Line 174: }
On 2009/06/17 22:18:49, levik wrote:
> What about the string "0"? What should that do?

The same thing it does in Javascript - coerce to true.

OTOH, the string "false" doesn't coerce to false in JS, so I could be pushed to
either:
  - Make "0" -> false
  - Or make "false" -> true
  - Or just leave things as they are

The current state is a bit inconsistent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b