Upgrade to JUEL 2.1.2 - Uses Ian Boston's temporary upload of JUEL 2.1.2 to a ...
14 years, 10 months ago
(2009-06-17 21:26:44 UTC)
#1
Upgrade to JUEL 2.1.2
- Uses Ian Boston's temporary upload of JUEL 2.1.2 to a maven repos, thanks Ian!
- Fixed boolean coercion to comply with the Opensocial spec
- Centralized Iterable and JSONArray coercion to no longer be gross hacks
- Stopped using default caching; instead use CacheProvider. Expression trees
are now cached using the LRU or ehcache caches, and can be configured
accordingly.
- Got rid of default constructor of Expressions (only useful for testing);
added Expressions.forTesting() method to access the same thing.
http://codereview.appspot.com/74075/diff/1/8 File java/common/src/test/java/org/apache/shindig/expressions/ExpressionsTest.java (right): http://codereview.appspot.com/74075/diff/1/8#newcode174 Line 174: } What about the string "0"? What should ...
14 years, 10 months ago
(2009-06-17 22:18:48 UTC)
#2
http://codereview.appspot.com/74075/diff/1/8 File java/common/src/test/java/org/apache/shindig/expressions/ExpressionsTest.java (right): http://codereview.appspot.com/74075/diff/1/8#newcode174 Line 174: } On 2009/06/17 22:18:49, levik wrote: > What ...
14 years, 10 months ago
(2009-06-17 23:29:55 UTC)
#3
http://codereview.appspot.com/74075/diff/1/8
File
java/common/src/test/java/org/apache/shindig/expressions/ExpressionsTest.java
(right):
http://codereview.appspot.com/74075/diff/1/8#newcode174
Line 174: }
On 2009/06/17 22:18:49, levik wrote:
> What about the string "0"? What should that do?
The same thing it does in Javascript - coerce to true.
OTOH, the string "false" doesn't coerce to false in JS, so I could be pushed to
either:
- Make "0" -> false
- Or make "false" -> true
- Or just leave things as they are
The current state is a bit inconsistent.
Issue 74075: Upgrade to JUEL 2.1.2
(Closed)
Created 14 years, 10 months ago by awiner
Modified 14 years, 9 months ago
Reviewers: levik, louiscryan
Base URL: https://svn.apache.org/repos/asf/incubator/shindig/trunk/
Comments: 2