Issue 7402052: Don't initialize dim_cache_ array via constructor syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7402052: Don't initialize dim_cache_ array via constructor syntax (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dak

Modified:
11 years, 1 month ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Don't initialize dim_cache_ array via constructor syntax This is not valid C++ and not even a documented GCC extension. It is probabably an oversight that GCC appears to be able to interpret this in some manner.

Patch Set 1 #

Patch Set 2 : Too ugly for words. See added comment. #

Patch Set 3 : Create a custom copy constructor for Dimension_cache instead #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	lily/dimension-cache.cc	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	lily/grob.cc	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	lily/include/dimension-cache.hh	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

11 years, 2 months ago (2013-02-23 14:00:07 UTC) #2

Create a custom copy constructor for Dimension_cache instead

Expand All Messages | Collapse All Messages