Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1744)

Issue 7382046: Make ly:make-unpure-pure-container accept a single callback (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by dak
Modified:
11 years, 2 months ago
Reviewers:
MikeSol
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make ly:make-unpure-pure-container accept a single callback Like with fixed values, this gets duplicated for the pure value as well, but converted into a three-argument callback.

Patch Set 1 #

Patch Set 2 : Allow arbitrary argument number #

Patch Set 3 : Change function signature to make for better error behavior #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M lily/unpure-pure-container.cc View 1 2 4 chunks +35 lines, -4 lines 0 comments Download

Messages

Total messages: 4
MikeSol
LGTM, with one suggestion: the difference between unpure and pure functions in LilyPond is that ...
11 years, 2 months ago (2013-02-21 19:35:35 UTC) #1
dak
On 2013/02/21 19:35:35, MikeSol wrote: > LGTM, with one suggestion: the difference between unpure and ...
11 years, 2 months ago (2013-02-21 19:54:00 UTC) #2
dak
Allow arbitrary argument number
11 years, 2 months ago (2013-02-21 20:07:36 UTC) #3
dak
11 years, 2 months ago (2013-02-21 23:11:19 UTC) #4
Change function signature to make for better error behavior
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b