Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 737041: Review: fix bug where optimize and closure assign collide (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by larrygritz
Modified:
15 years, 1 month ago
Reviewers:
ckulla
CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

OK, trying to explain this. Ci *= color_C is legal Ci = 0 is legal as a special case (clear the closure) but X *= (zero valued thing) gets optimized to X = (zero valued thing) So, we were turning color_C = ...; Ci *= color_C; into color_const = 0; Ci = color_const; and were hitting a runtime assertion. Oops. No worries, just fix the runtime.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
src/liboslexec/opassign.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
larrygritz
15 years, 1 month ago (2010-03-24 21:32:02 UTC) #1
ckulla
15 years, 1 month ago (2010-03-24 21:36:50 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b