Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(526)

Issue 73610044: Count MIDI ticks from the beginning of the score, not each staff independently.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by Devon Schudy
Modified:
10 years ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Count MIDI ticks from the beginning of the score, not each staff independently. This keeps MIDI output aligned for: * Lyrics (issue 3878) * Staves without Dynamic_performer (issue 3871) * Staves that start late * Scores that start with grace notes (issue 1412). Is there a cleaner way to get the starting tick? Ideally we should count from the first moment of the score, not the first Audio_item.

Patch Set 1 #

Patch Set 2 : Get starting time from first_mom instead of the first Audio_item. #

Total comments: 1

Patch Set 3 : Add midiStart property. #

Total comments: 1

Patch Set 4 : Store midiStart as a moment to avoid GC issues. #

Total comments: 1

Patch Set 5 : Use output-def instead of context. Documentation. #

Patch Set 6 : No more overriding option. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M lily/audio-staff.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/audio-staff.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/midi-walker.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/midi-walker.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M lily/performance.cc View 1 2 3 4 5 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 12
dak
That approach seems too contorted. The Global context is the one doing the iteration, so ...
10 years ago (2014-03-11 19:46:52 UTC) #1
Devon Schudy
Get starting time from first_mom instead of the first Audio_item.
10 years ago (2014-03-19 04:45:43 UTC) #2
dak
I am not particularly happy with the amount of code for getting the starting position. ...
10 years ago (2014-03-19 08:19:49 UTC) #3
Devon Schudy
Add midiStart property.
10 years ago (2014-03-25 16:22:27 UTC) #4
Devon Schudy
Performance::start_ saves a Scheme value. Does that mean it needs to override derived_mark to scm_gc_mark ...
10 years ago (2014-03-27 16:22:54 UTC) #5
dak
And you are right about derived_mark. That's needed. https://codereview.appspot.com/73610044/diff/40001/lily/performance.cc File lily/performance.cc (right): https://codereview.appspot.com/73610044/diff/40001/lily/performance.cc#newcode64 lily/performance.cc:64: if ...
10 years ago (2014-03-27 16:42:04 UTC) #6
Devon Schudy
Store midiStart as a moment to avoid GC issues.
10 years ago (2014-03-28 20:09:35 UTC) #7
dak
https://codereview.appspot.com/73610044/diff/60001/lily/score-performer.cc File lily/score-performer.cc (right): https://codereview.appspot.com/73610044/diff/60001/lily/score-performer.cc#newcode181 lily/score-performer.cc:181: performance_ = new Performance(context ()->get_property ("midiStart")); Stupid question: when ...
10 years ago (2014-03-28 20:26:03 UTC) #8
Devon Schudy
dak wrote: > Stupid question: when is midiStart available if it is a context > ...
10 years ago (2014-03-29 00:44:17 UTC) #9
Devon Schudy
Use output-def instead of context. Documentation.
10 years ago (2014-03-29 02:57:38 UTC) #10
dak
On 2014/03/29 00:44:17, Devon Schudy wrote: > dak wrote: > > If not (I actually ...
10 years ago (2014-03-29 07:54:07 UTC) #11
Devon Schudy
10 years ago (2014-03-30 05:38:24 UTC) #12
No more overriding option.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b