Issue 736041: Lilypond issues success/failure termination message

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 736041: Lilypond issues success/failure termination message

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Ian Hulin

Modified:
14 years ago

Reviewers:
Patrick McCarty

CC:
frogs_lilynet.net, lilypond-devel_gnu.org

Visibility:
Public.

Description

Lilypond issues success/failure termination message Add a message to indicate the Lilypond has completed a compilation.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Responses to feedack from Patrick #

Patch Set 3 : Reloading patch after git repository changeover #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -16 lines)			Patch
M	flower/include/warn.hh	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	flower/warn.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	lily/general-scheme.cc	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download
M	scm/lily.scm	View	1 2	7 chunks	+28 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Patrick McCarty

Hi Ian, I haven't actually tested this patch, but here are a few comments. http://codereview.appspot.com/736041/diff/1/5 ...

14 years ago (2010-03-24 21:59:21 UTC) #1

Ian Hulin

14 years ago (2010-03-24 22:49:42 UTC) #2

http://codereview.appspot.com/736041/diff/1/5
File scm/lily.scm (right):

http://codereview.appspot.com/736041/diff/1/5#newcode262
scm/lily.scm:262: 
On 2010/03/24 21:59:22, Patrick McCarty wrote:
> I removed this 'gettext wrapper because LilyPond only supports Guile 1.8.2 or
> later.
> 
> Do we really want to reinstate this?
No - will revert it.
Done

http://codereview.appspot.com/736041/diff/1/5#newcode296
scm/lily.scm:296: 
On 2010/03/24 21:59:22, Patrick McCarty wrote:
> These commented lines should be part of a separate patch.

Done.

http://codereview.appspot.com/736041/diff/1/5#newcode763
scm/lily.scm:763: (if (= (random 40) 1)
On 2010/03/24 21:59:22, Patrick McCarty wrote:
> You need to rebase again.

Done.

Expand All Messages | Collapse All Messages