showFirstLength

showFirstLength




* new showFirstLength feature
This commit implements a showFirstLength property, that does
the opposite of showLastLength (both properties may be set,
in this case the beginning and the end of the piece are printed,
with a double barline as a separator).

When only showFirstLength is set, the 'length property is
overriden (except if already shorter than the specified first
length) and therefore the compilation will be much faster.

This new feature may be very convenient, e.g. to print the
index of a book containing only the beginning of each \score.

[hanwenn, 2008-10-20 12:17:00]

http://codereview.appspot.com/7317/diff/1/4
File scm/music-functions.scm (right):

http://codereview.appspot.com/7317/diff/1/4#newcode827
Line 827: "set skipTypesetting, make SkipMusic of the given MUS length,
update doc string mus suggests music argument, but you are passing a moment.

http://codereview.appspot.com/7317/diff/1/4#newcode836
Line 836: (ly:moment-main-denominator mus)))
this looks like a good candidate for a function 

  make-duration-of-music-length

http://codereview.appspot.com/7317/diff/1/4#newcode841
Line 841: "unset skipTypesetting if set, make SkipMusic of the given MUS length,
update doc string: you're always unsetting

http://codereview.appspot.com/7317/diff/1/4#newcode843
Line 843: (make-sequential-music
fix indent ; use emacs indent-region

http://codereview.appspot.com/7317/diff/1/4#newcode867
Line 867: ((show-last  (ly:parser-lookup parser 'showLastLength))
one space after var name.

http://codereview.appspot.com/7317/diff/1/4#newcode884
Line 884: 'symbol 'whichBar)))
you may want to do this in 'Timing context.

[Valentin Villenave, 2008-10-20 17:57:44]

I don't know what to do next; should I open a new issue with the updated code?
Or is it possible to upload a new patch within the same issue?

http://codereview.appspot.com/7317/diff/1/4
File scm/music-functions.scm (right):

http://codereview.appspot.com/7317/diff/1/4#newcode827
Line 827: "set skipTypesetting, make SkipMusic of the given MUS length,
On 2008/10/20 12:17:00, hanwenn wrote:
> update doc string mus suggests music argument, but you are passing a moment.

Done.

http://codereview.appspot.com/7317/diff/1/4#newcode836
Line 836: (ly:moment-main-denominator mus)))
On 2008/10/20 12:17:00, hanwenn wrote:
> this looks like a good candidate for a function 
> 
>   make-duration-of-music-length
> 

Done.

http://codereview.appspot.com/7317/diff/1/4#newcode836
Line 836: (ly:moment-main-denominator mus)))
On 2008/10/20 12:17:00, hanwenn wrote:
> this looks like a good candidate for a function 
> 
>   make-duration-of-music-length
> 

would a define-public be potentially useful here?

Where should I put this function?
There's already a (remotely related) skip-of-length function at the bottom of
this file; should I move all debugging-related functions to the bottom as well?

http://codereview.appspot.com/7317/diff/1/4#newcode841
Line 841: "unset skipTypesetting if set, make SkipMusic of the given MUS length,
On 2008/10/20 12:17:00, hanwenn wrote:
> update doc string: you're always unsetting

Done.

http://codereview.appspot.com/7317/diff/1/4#newcode843
Line 843: (make-sequential-music
On 2008/10/20 12:17:00, hanwenn wrote:
> fix indent ; use emacs indent-region

Done.

http://codereview.appspot.com/7317/diff/1/4#newcode867
Line 867: ((show-last  (ly:parser-lookup parser 'showLastLength))
On 2008/10/20 12:17:00, hanwenn wrote:
> one space after var name.

Done.

http://codereview.appspot.com/7317/diff/1/4#newcode884
Line 884: 'symbol 'whichBar)))
On 2008/10/20 12:17:00, hanwenn wrote:
> you may want to do this in 'Timing context.

Done.

[hanwenn, 2008-10-21 00:37:54]

Looks good to me.

http://codereview.appspot.com/7317/diff/7/8
File input/regression/skiptypesetting-show-last-or-first.ly (right):

http://codereview.appspot.com/7317/diff/7/8#newcode25
Line 25: showFirstLength = R1
can you double check that this will actually compare the way you think it will
in the regtest? (ie. changes in all three scores will hit the regtest?)

You could also split this into three files.

http://codereview.appspot.com/7317/diff/7/10
File scm/music-functions.scm (right):

http://codereview.appspot.com/7317/diff/7/10#newcode830
Line 830: (ly:moment-main-numerator moment)
this indent also looks off.

[Valentin Villenave, 2008-10-21 08:10:05]

OK. I have eventually left the skiptypesetting-show-last regtest, and added two
more regtests (skiptypesetting-show-first, skiptypesetting-show-first-and-last).

Since I have your LGTM, I pushed the commit.

http://codereview.appspot.com/7317/diff/7/8
File input/regression/skiptypesetting-show-last-or-first.ly (right):

http://codereview.appspot.com/7317/diff/7/8#newcode25
Line 25: showFirstLength = R1
On 2008/10/21 00:37:54, hanwenn wrote:
> can you double check that this will actually compare the way you think it will
> in the regtest? (ie. changes in all three scores will hit the regtest?)
> 
> You could also split this into three files.

Done.

http://codereview.appspot.com/7317/diff/7/10
File scm/music-functions.scm (right):

http://codereview.appspot.com/7317/diff/7/10#newcode830
Line 830: (ly:moment-main-numerator moment)
On 2008/10/21 00:37:54, hanwenn wrote:
> this indent also looks off. 
> 

Done.