https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm File scm/skyline.scm (right): https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm#newcode23 scm/skyline.scm:23: (define-public (skyline-pair::useable? skyp) So why is this not non-empty-skyline-pair? ...
11 years, 2 months ago
(2013-02-20 15:27:49 UTC)
#1
https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm
File scm/skyline.scm (right):
https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm#newcode23
scm/skyline.scm:23: (define-public (skyline-pair::useable? skyp)
So why is this not non-empty-skyline-pair? or skyline-pair-and-non-empty? It is
nice that you add a comment explaining an incomprehensible term in about the
same space that the incomprehensible term takes, but why? "useable?" is merely
an obfuscation of "non-empty?" and does not imply a check for being a skyline
pair at all any more than "non-empty?" does. So why obfuscate the name in the
first place? We don't get prices for new word creations.
On 2013/02/20 15:27:49, dak wrote: > https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm > File scm/skyline.scm (right): > > https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm#newcode23 > ...
11 years, 2 months ago
(2013-02-20 15:32:22 UTC)
#2
On 2013/02/20 15:27:49, dak wrote:
> https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm
> File scm/skyline.scm (right):
>
> https://codereview.appspot.com/7313082/diff/1/scm/skyline.scm#newcode23
> scm/skyline.scm:23: (define-public (skyline-pair::useable? skyp)
> So why is this not non-empty-skyline-pair? or skyline-pair-and-non-empty?
And if for some reason you really, really, want to start this off with
"skyline-pair::", then "skyline-pair::and-non-empty?" will perfectly bring
across checking for both being a skyline pair and non-empty.
Issue 7313082: Fixes annotate spacing
(Closed)
Created 11 years, 2 months ago by MikeSol
Modified 11 years, 1 month ago
Reviewers: dak
Base URL:
Comments: 1