Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(146)

Issue 7311074: Corrects links to manuals in many languages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by PhilEHolmes
Modified:
11 years, 1 month ago
Reviewers:
Graham Percival, email
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

A number of the links on the Development pages for the various languages point to pages that don't exist (e.g. the Czech page http://lilypond.org/development.cs.html) or don't point to translated pages when they do exist (e.g. http://lilypond.org/development.it.html). This patch _should_ fix many of these. It's difficult to test properly, since it relies on interactions between make doc in GUB and make website on the server. However, I believe it's a step forward and would like to get it into master fairly quickly.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -561 lines) Patch
M Documentation/cs/web/community.itexi View 3 chunks +27 lines, -27 lines 0 comments Download
D Documentation/cs/web/news-front.itexi View 1 chunk +0 lines, -16 lines 1 comment Download
D Documentation/hu/web/basic-authors.itexi View 1 chunk +0 lines, -392 lines 1 comment Download
M Documentation/hu/web/community.itexi View 3 chunks +94 lines, -108 lines 0 comments Download
M Documentation/it/web/community.itexi View 3 chunks +15 lines, -15 lines 0 comments Download
M Documentation/zh/web/community.itexi View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
PhilEHolmes
Please review.
11 years, 2 months ago (2013-02-11 12:57:52 UTC) #1
Graham Percival
https://codereview.appspot.com/7311074/diff/1/Documentation/cs/web/news-front.itexi File Documentation/cs/web/news-front.itexi (left): https://codereview.appspot.com/7311074/diff/1/Documentation/cs/web/news-front.itexi#oldcode11 Documentation/cs/web/news-front.itexi:11: @subsubheading LilyPond 2.13.47 released! @emph{Jan 28, 2011} Since news-front.itexi ...
11 years, 2 months ago (2013-02-13 07:01:22 UTC) #2
email_philholmes.net
11 years, 2 months ago (2013-02-13 18:32:43 UTC) #3
----- Original Message ----- 
From: <graham@percival-music.ca>
To: <PhilEHolmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Wednesday, February 13, 2013 7:01 AM
Subject: Re: Corrects links to manuals in many languages (issue 7311074)


>
>
https://codereview.appspot.com/7311074/diff/1/Documentation/cs/web/news-front...
> File Documentation/cs/web/news-front.itexi (left):
>
>
https://codereview.appspot.com/7311074/diff/1/Documentation/cs/web/news-front...
> Documentation/cs/web/news-front.itexi:11: @subsubheading LilyPond
> 2.13.47 released!  @emph{Jan 28, 2011}
> Since news-front.itexi is included in web.itexi, I suspect that deleting
> this file would cause the entire build to break.  Did you mean to edit
> hu/web.texi as well?

Well...  If news-front isn't in the translation, it's found in the en build 
and used.  Most of the translations work like this.  Except it does cause a 
make website to break, because of the links file which is previously 
created.  Can't remember the exact name.  Locally, I fixed this by nuking 
build and rebuilding from scratch, and all was well.  As it turned out, the 
website build on the server failed for the same reason, so I resorted to 
renaming the build directory on the server and it rebuilt from scratch, so 
all appears OK.

> I would rather leave this file alone, or possibly add a "news" item
> saying "this translation is out of date".
>
>
https://codereview.appspot.com/7311074/diff/1/Documentation/hu/web/basic-auth...
> File Documentation/hu/web/basic-authors.itexi (left):
>
>
https://codereview.appspot.com/7311074/diff/1/Documentation/hu/web/basic-auth...
> Documentation/hu/web/basic-authors.itexi:100: LilyPond Kódrészletek
> Tárházának szerkesztője, hibafelelős
> woah, why delete this translated file?

It was a very out of date file and not used anywhere in the build.

> https://codereview.appspot.com/7311074/

Thanks for the comments.  Appreciated.

BTW - my recent patches have corrected a _lot_ of broken and missing links. 
Prior to this, all of the links on http://lilypond.org/glossary.hu.html were 
broken.  This was true for most of the .hu and .cs docs.  They now all go to 
a page that exists.

--
Phil Holmes 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b