Issue 7306053: Remove code duplication for cue clefs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7306053: Remove code duplication for cue clefs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dak

Modified:
11 years, 2 months ago

Reviewers:
marc

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove code duplication for cue clefs Attentive observers will notice that clef->cueclef can not only convert property-setting music but also context mods.

Patch Set 1 #

Patch Set 2 : Fix thinko (there is no make-clef-unset to use) and drop context-mod support #

Patch Set 3 : Fix clueless typo 'clue-clef-map' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -65 lines)			Patch
	M	scm/parser-clef.scm	View	1 2	1 chunk	+21 lines, -65 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dak

Fix thinko (there is no make-clef-unset to use) and drop context-mod support

11 years, 2 months ago (2013-02-06 14:51:30 UTC) #1

marc

11 years, 2 months ago (2013-02-06 20:46:57 UTC) #3

On 2013/02/06 14:57:05, dak wrote:
> Fix clueless typo 'clue-clef-map'

LGTM

Expand All Messages | Collapse All Messages