Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3640)

Issue 7303067: This is actually a whole bunch of commits: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by dak
Modified:
11 years, 2 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This is actually a whole bunch of commits: Remove obsolete @knownissue about fingerings like -23 Issue 3034: Use \finger in a few documentation places Simplify definition of \thumb Remove definition of \finger from double fingering regtest Add explicit \finger command for normal fingering events Let \rightHandFinger accept arbitrary markup as text Add number-or-markup? predicate Let calc-{fingering,string-number,stroke-finger}::calc-text look at event 'text This slightly increases the number of property lookups, and the same function can be achieved using a tweak. However, it seems more natural to attach any overriding text (in the case of non-standard elements like thumbs or other) directly to the event in question.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -36 lines) Patch
M Documentation/notation/editorial.itely View 2 chunks +2 lines, -6 lines 1 comment Download
M Documentation/notation/text.itely View 1 chunk +1 line, -5 lines 0 comments Download
M Documentation/snippets/creating-double-digit-fingerings.ly View 2 chunks +1 line, -6 lines 0 comments Download
M ly/music-functions-init.ly View 2 chunks +11 lines, -3 lines 0 comments Download
M ly/script-init.ly View 1 chunk +2 lines, -3 lines 0 comments Download
M scm/c++.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +10 lines, -13 lines 0 comments Download

Messages

Total messages: 2
Keith
https://codereview.appspot.com/7303067/diff/1/Documentation/notation/editorial.itely File Documentation/notation/editorial.itely (right): https://codereview.appspot.com/7303067/diff/1/Documentation/notation/editorial.itely#newcode157 Documentation/notation/editorial.itely:157: Markup texts or strings may be used for finger ...
11 years, 2 months ago (2013-02-10 20:42:35 UTC) #1
dak
11 years, 2 months ago (2013-02-11 08:11:00 UTC) #2
On 2013/02/10 20:42:35, Keith wrote:
>
https://codereview.appspot.com/7303067/diff/1/Documentation/notation/editoria...
> File Documentation/notation/editorial.itely (right):
> 
>
https://codereview.appspot.com/7303067/diff/1/Documentation/notation/editoria...
> Documentation/notation/editorial.itely:157: Markup texts or strings may be
used
> for finger changes.
> Not strings in general, because the font is the music font by default. 
General
> strings would have a in some default font, but p in the font for the dynamic
> 'piano'

I did not write "arbitrary strings".  "string" just implies a data type, not
what characters it may contain.  We are also talking about fingerings here and
nothing else.  If you think that the text needs changes, please propose what you
consider appropriate instead.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b