Issue 7300086: Invert the meaning of instrumentTransposition again.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7300086: Invert the meaning of instrumentTransposition again. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dak

Modified:
11 years, 2 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Invert the meaning of instrumentTransposition again. The problem is that all of the available user-level documentation (like with instrument definitions) does not really match the sign of instrumentTransposition that has been chosen (and flipped back and forth) in order to let the bug fixed with issue 754 result in audible pitches that have some relation of not purely mathematical interest to the input. As this incentive is no longer present, it makes no sense to maintain this incomprehensible sign convention. This basically reverts commit 1965ca6b70aaf2c04a25ace9ed3f1fb4e1222f5a and the preceding one. Files affected: lily/note-performer.cc lily/quote-iterator.cc ly/music-functions-init.ly scm/define-context-properties.scm Adapt input/regression/quote-transposition.ly to new realities This currently includes the patches for issue 754 and will need to get rebased once those make it to master.

Patch Set 1 #

Patch Set 2 : Rebase on current master #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -9 lines)			Patch
M	lily/note-performer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/quote-iterator.cc	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	ly/music-functions-init.ly	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	scm/define-context-properties.scm	View	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Looks and sounds fine to me.

Expand All Messages | Collapse All Messages