Issue 7256: Inlining of ${Msg} values at compile time, whitespace trimming.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7256: Inlining of ${Msg} values at compile time, whitespace trimming.

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by levik

Modified:
10 years, 8 months ago

Reviewers:
shindig-dev

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

This is obsolete: see http://codereview.appspot.com/7257 instead Any ${Msg.foo} reference will be inlined into the template during compilation, which will result in all the ${} style markup in the message body to be properly processed. So if there is a message that contains "Hello ${Viewer.displayName}", it will work as expected. This will allow more flexibility in internationalization. Additionally, added trimming of string contents of template source obtained from DOM nodes. JIRA Issue: https://issues.apache.org/jira/browse/SHINDIG-645

Patch Set 1 #

Patch Set 2 : fixed issues pointed out by John Fargo #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
features/opensocial-templates/base.js	View		3 chunks	+2 lines, -9 lines	0 comments	Download
features/opensocial-templates/compiler.js	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
features/opensocial-templates/util.js	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

johnfargo

16 years, 11 months ago (2008-10-06 18:55:26 UTC) #2

Few short comments.

http://codereview.appspot.com/7256/diff/1/3
File features/opensocial-templates/compiler.js (right):

http://codereview.appspot.com/7256/diff/1/3#newcode857
Line 857: // (and gadget messages are obtaibable), inline it here.
s/obtaibable/obtainable

http://codereview.appspot.com/7256/diff/1/3#newcode861
Line 861: var key = token.split(".")[1];
Handling of syntax errors eg. no "." present?

Expand All Messages | Collapse All Messages