Issue 7231072: \note-by-number supports flag-styles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7231072: \note-by-number supports flag-styles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by thomasmorley65

Modified:
11 years, 2 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

\note-by-number supports flag-styles Issue 3104 For mensural and neomensural the flag is changed due to the note-head-style. Straight flags are possible using the new introduced flag-style-property

Patch Set 2 : Including David's suggestions #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -114 lines)			Patch
M	input/regression/markup-note.ly	View		1 chunk	+50 lines, -44 lines	0 comments	Download
M	input/regression/markup-note-styles.ly	View		2 chunks	+38 lines, -13 lines	0 comments	Download
M	scm/define-markup-commands.scm	View	1	5 chunks	+148 lines, -57 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

thomasmorley65

Please review. The regtests markup-note.ly and markup-note-styles.ly are modified. Changes are expected.

11 years, 3 months ago (2013-01-31 22:29:53 UTC) #1

dak

https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm#newcode3366 scm/define-markup-commands.scm:3366: (string-append "flags." I'd rather use (format #f (if ancient-flags? ...

11 years, 3 months ago (2013-02-02 16:11:19 UTC) #2

thomasmorley65

11 years, 3 months ago (2013-02-03 14:09:17 UTC) #5

Don't know why two identical patch-sets were uploaded

On 2013/02/02 16:11:19, dak wrote:
> https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm
> File scm/define-markup-commands.scm (right):
> 
>
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm#...
> scm/define-markup-commands.scm:3366: (string-append "flags."
> I'd rather use
>   (format #f (if ancient-flags? "flags.mensural~a2~a"
>                                 "flags.~a~a")
>              (if (> dir 0) "u" "d") log)
> here.  It is somewhat more readable.

Changed.

> 
>
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm#...
> scm/define-markup-commands.scm:3387: (or (eq? flag-style 'default) (list?
> flag-style))
> Why (list? flag-style)?  Is that a tricky obfuscation of (null? flag-style)?

Rather bad thinking.
Changed.

Expand All Messages | Collapse All Messages