Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3687)

Issue 7220052: Make documentation reflect presence of \tuplet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dak
Modified:
11 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make documentation reflect presence of \tuplet This is a followup issue to the changes introduced by issue 3095.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adjust Changes along Keith's suggestions #

Total comments: 3

Patch Set 3 : Integrate further suggestions from Keith #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -40 lines) Patch
M Documentation/changes.tely View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Documentation/contributor/administration.itexi View 1 chunk +1 line, -2 lines 0 comments Download
M Documentation/learning/common-notation.itely View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M Documentation/music-glossary.tely View 7 chunks +10 lines, -10 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 2 3 chunks +24 lines, -12 lines 0 comments Download
M Documentation/notation/simultaneous.itely View 1 chunk +1 line, -1 line 0 comments Download
A + Documentation/snippets/new/changing-the-tuplet-number.ly View 2 chunks +2 lines, -9 lines 0 comments Download
A Documentation/snippets/new/entering-several-tuplets-using-only-one--times-command.ly View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11
Keith
Looks great. You can simplify the version in changes. The two tuplets sharing share one ...
11 years, 3 months ago (2013-01-29 04:47:13 UTC) #1
dak
On 2013/01/29 04:47:13, Keith wrote: > Looks great. > > You can simplify the version ...
11 years, 3 months ago (2013-01-29 09:23:03 UTC) #2
dak
Adjust Changes along Keith's suggestions
11 years, 3 months ago (2013-01-29 09:46:44 UTC) #3
Keith
> If you consider that description better than the original, > you might want to ...
11 years, 3 months ago (2013-01-29 17:25:19 UTC) #4
Jean-Charles
On 2013/01/29 17:25:19, Keith wrote: > I tried to write simpler texts, below. If you ...
11 years, 3 months ago (2013-01-29 18:54:50 UTC) #5
dak
On 2013/01/29 17:25:19, Keith wrote: > https://codereview.appspot.com/7220052/diff/4001/Documentation/learning/common-notation.itely#newcode506 > Documentation/learning/common-notation.itely:506: ratio of the number of notes ...
11 years, 3 months ago (2013-01-30 10:41:50 UTC) #6
benko.pal
2013/1/30 <dak@gnu.org>: > On 2013/01/29 17:25:19, Keith wrote: > > > https://codereview.appspot.com/7220052/diff/4001/Documentation/learning/common-notation.itely#newcode506 >> >> Documentation/learning/common-notation.itely:506: ...
11 years, 3 months ago (2013-01-30 10:54:30 UTC) #7
dak
Integrate further suggestions from Keith
11 years, 3 months ago (2013-01-30 11:00:24 UTC) #8
dak
On 2013/01/30 10:41:50, dak wrote: > We have a fundamental difference in our terminology. > ...
11 years, 3 months ago (2013-01-30 11:32:37 UTC) #9
Trevor Daniels
On 2013/01/30 11:32:37, dak wrote: > On 2013/01/30 10:41:50, dak wrote: > > We have ...
11 years, 3 months ago (2013-01-30 11:48:36 UTC) #10
Keith
11 years, 3 months ago (2013-01-30 18:45:04 UTC) #11
On Wed, 30 Jan 2013 02:41:50 -0800, <dak@gnu.org> wrote:

> For you, a triplet consists of three notes.  For me, a triplet consists
> of a single note, three of which make up a triplet group.

> The Wikipedia entry http://en.wikipedia.org/wiki/Tuplet oscillates
> between both uses, mathematically of course a triplet is a group.
>

The difficulty is that 'tuplet' can be an adjective in 'tuplet quarter note'.

The German http://de.wikipedia.org/wiki/Notenwert#Triole
is more helpful: A 'Triole' is a group of (e.g.) three equal-length notes
immediately following one another, that has total duration of only two such
note-values.
And the grammar makes clear when Triolen is an adjective.  Vierteltriole is the
group, Triolen-Viertel is one quarter note in the group.

The text in the patch is still perfectly clear.

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b