Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4022)

Issue 7205057: Move Timing into separate context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dak
Modified:
11 years, 3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Move Timing into separate context The advantage over an alias at Score level is that setting Timing variables before a Score context is established does not lead to error messages. Having a real, mostly ignored Timing context as a subcontext of Score is a bit ugly, though. An alternative would be to establish a Timing alias for Global instead since Global is always present. It would be somewhat unusual to manipulate Global variables, however. It can't be an alternative to actually _accept_ Timing at Global level since get_score_context relies on Score being the only subcontext of Global. The last commit concerns just ly/engraver-init.ly and ly/performer-init.ly There are two additional commits: Make Timing_translator do a more thorough job of initializing Timing Touches lily/timing-translator.cc Replace base-fraction with base-length to simplify calculations touches scm/define-music-callbacks.scm and scm/time-signature-settings.scm

Patch Set 1 #

Patch Set 2 : Timing context in performer-init.ly belongs to Performer_group #

Patch Set 3 : Without creating the Timing context, there will be nothing to be found #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -54 lines) Patch
M lily/timing-translator.cc View 1 2 3 chunks +74 lines, -9 lines 0 comments Download
M ly/engraver-init.ly View 1 2 3 chunks +17 lines, -17 lines 0 comments Download
M ly/performer-init.ly View 1 2 3 chunks +17 lines, -12 lines 0 comments Download
M scm/define-music-callbacks.scm View 2 chunks +4 lines, -4 lines 0 comments Download
M scm/time-signature-settings.scm View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2
dak
Timing context in performer-init.ly belongs to Performer_group
11 years, 3 months ago (2013-01-25 16:37:55 UTC) #1
dak
11 years, 3 months ago (2013-01-26 09:44:12 UTC) #2
Without creating the Timing context, there will be nothing to be found
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b