Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(735)

Issue 71960043: Issue 3876: Fix shape of G clefs

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by lemzwerg
Modified:
10 years ago
Reviewers:
marc
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3876: Fix shape of G clefs This patch simplifies the code for the double G clefs; it also fixes the incorrect test of the `double_shift' parameter that caused the non-double G clefs being drawn twice. Recent FontForge warnings like Internal Error (overlap) in clefs.G: Intersection failed! or the ugly shape with a straight line instead of a curve in the left part of the G clef are now gone: Drawing the shape twice triggered a bunch of FontForge bugs.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M mf/feta-clefs.mf View 1 chunk +3 lines, -23 lines 1 comment Download

Messages

Total messages: 1
marc
10 years ago (2014-03-06 07:42:40 UTC) #1
https://codereview.appspot.com/71960043/diff/1/mf/feta-clefs.mf
File mf/feta-clefs.mf (right):

https://codereview.appspot.com/71960043/diff/1/mf/feta-clefs.mf#newcode561
mf/feta-clefs.mf:561: currentpicture shifted (double_shift * reduced_ss, 0);
Wow – a lot better! LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b