Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Delta Between Two Patch Sets: gears/database2/statement.h

Issue 717: Database2Values, argument conversion implemented (Closed) SVN Base: http://google-gears.googlecode.com/svn/contrib/dimitri.glazkov/database2/
Left Patch Set: Created 4 months ago
Right Patch Set: ready for another look. Created 3 months, 3 weeks ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 // Copyright 2008, Google Inc. 1 // Copyright 2008, Google Inc.
2 // 2 //
3 // Redistribution and use in source and binary forms, with or without 3 // Redistribution and use in source and binary forms, with or without
4 // modification, are permitted provided that the following conditions are met: 4 // modification, are permitted provided that the following conditions are met:
5 // 5 //
6 // 1. Redistributions of source code must retain the above copyright notice, 6 // 1. Redistributions of source code must retain the above copyright notice,
7 // this list of conditions and the following disclaimer. 7 // this list of conditions and the following disclaimer.
8 // 2. Redistributions in binary form must reproduce the above copyright notice, 8 // 2. Redistributions in binary form must reproduce the above copyright notice,
9 // this list of conditions and the following disclaimer in the documentation 9 // this list of conditions and the following disclaimer in the documentation
10 // and/or other materials provided with the distribution. 10 // and/or other materials provided with the distribution.
11 // 3. Neither the name of Google Inc. nor the names of its contributors may be 11 // 3. Neither the name of Google Inc. nor the names of its contributors may be
12 // used to endorse or promote products derived from this software without 12 // used to endorse or promote products derived from this software without
13 // specific prior written permission. 13 // specific prior written permission.
14 // 14 //
15 // THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED 15 // THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
16 // WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 16 // WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
17 // MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO 17 // MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
18 // EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 18 // EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
19 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 19 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
20 // PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; 20 // PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
21 // OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, 21 // OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
22 // WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 22 // WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
23 // OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 23 // OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
24 // ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 // ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 25
26 #ifndef GEARS_DATABASE2_STATEMENT_H__ 26 #ifndef GEARS_DATABASE2_STATEMENT_H__
27 #define GEARS_DATABASE2_STATEMENT_H__ 27 #define GEARS_DATABASE2_STATEMENT_H__
28 28
29 #include "gears/base/common/common.h" 29 #include "gears/base/common/common.h"
30 #include "gears/base/common/js_types.h" 30 #include "gears/base/common/js_types.h"
31 #include "gears/third_party/scoped_ptr/scoped_ptr.h" 31 #include "gears/third_party/scoped_ptr/scoped_ptr.h"
32 32
33 // forward declarations 33 // forward declarations
34 class Database2; 34 class Database2;
35 class Database2Transaction; 35 class Database2Transaction;
36 class Database2Values; 36 class Database2Values;
37 37
38 // represents statement, for both synchronous and asynchronous operations 38 // represents statement, for both synchronous and asynchronous operations
39 class Database2Statement { 39 class Database2Statement {
40 public: 40 public:
41 bool HasCallback() const { 41 bool HasCallback() const {
42 assert(callback_.get()); 42 return callback_.get() != NULL;
43 return !JsTokenIsNullOrUndefined(callback_->token());
44 } 43 }
45 44
46 bool HasErrorCallback() const { 45 bool HasErrorCallback() const {
47 assert(error_callback_.get()); 46 return error_callback_.get() != NULL;
48 return !JsTokenIsNullOrUndefined(error_callback_->token());
49 } 47 }
50 48
51 void InvokeCallback(Database2Transaction *tx); 49 void InvokeCallback(Database2Transaction *tx);
52 void InvokeErrorCallback(Database2Transaction *tx, JsObject *error); 50 void InvokeErrorCallback(Database2Transaction *tx, JsObject *error);
53 51
52 // create a statement instance
53 // must passs NULL for arguments or callbacks if they are not specified
54 static bool Create(const std::string16 &sql_statement, 54 static bool Create(const std::string16 &sql_statement,
55 const JsArray &sql_arguments, 55 JsArray *sql_arguments,
56 JsRootedCallback *callback, 56 JsRootedCallback *callback,
57 JsRootedCallback *error_callback, 57 JsRootedCallback *error_callback,
58 Database2Statement **instance); 58 Database2Statement **instance);
59 59
60 std::string16 sql() const { return sql_statement_; } 60 std::string16 sql() const { return sql_statement_; }
61 Database2Values *arguments() const { return arguments_.get(); } 61 Database2Values *arguments() const { return arguments_.get(); }
62 private: 62 private:
63 Database2Statement() {} 63 Database2Statement() {}
64 // if true, the statement has invalid arguments 64 // if true, the statement has invalid arguments
65 bool bogus_; 65 bool bogus_;
66 std::string16 sql_statement_; 66 std::string16 sql_statement_;
67 scoped_ptr<Database2Values> arguments_; 67 scoped_ptr<Database2Values> arguments_;
68 scoped_ptr<JsRootedCallback> callback_; 68 scoped_ptr<JsRootedCallback> callback_;
69 scoped_ptr<JsRootedCallback> error_callback_; 69 scoped_ptr<JsRootedCallback> error_callback_;
70 70
71 DISALLOW_EVIL_CONSTRUCTORS(Database2Statement); 71 DISALLOW_EVIL_CONSTRUCTORS(Database2Statement);
72 }; 72 };
73 73
74 // used for marshaling statement arguments to the database thread and 74 // Used for marshaling statement arguments to the database thread and
75 // results to the main thread 75 // results to the main thread.
76 // JsParamToSend is used to store the value-type pairs, and as a result the
77 // values are heap-allocated, which is unfortunate in the case of int/double.
78 // TODO(dimitri.glazkov): Reimplement using unions, possibly reusing or
79 // integrating with MarshaledJsToken
76 class Database2Values { 80 class Database2Values {
77 public: 81 public:
78 ~Database2Values(); 82 ~Database2Values();
79 83
80 static bool CreateFromJsArray(const JsArray &sql_arguments, 84 static bool CreateFromJsArray(const JsArray *sql_arguments,
81 Database2Values **instance); 85 Database2Values **instance);
82 86
83 int length() const { return length_; } 87 int length() const { return length_; }
84 JsParamType GetType(int index) const; 88 JsParamType GetType(int index) const;
85 int GetAsInt(int index) const; 89 int GetAsInt(int index) const;
86 double GetAsDouble(int index) const; 90 double GetAsDouble(int index) const;
87 std::string16 &GetAsString(int index) const; 91 std::string16 &GetAsString(int index) const;
88 private: 92 private:
89 Database2Values() {} 93 Database2Values() {}
90 94
91 static bool SetJsParamToSend(JsArray js_array, 95 static bool SetJsParamToSend(const JsArray *js_array,
92 int index, 96 int index,
93 JsParamToSend *param); 97 JsParamToSend *param);
94 98
95 scoped_array<JsParamToSend> arguments_; 99 scoped_array<JsParamToSend> arguments_;
96 int length_; 100 int length_;
Aaron 2008/05/11 18:11:21 Should length be passed separately? The way it is
Dimitri 2008/05/13 22:52:03 On 2008/05/11 18:11:21, Aaron wrote: > Should leng
97 101
98 DISALLOW_EVIL_CONSTRUCTORS(Database2Values); 102 DISALLOW_EVIL_CONSTRUCTORS(Database2Values);
99 }; 103 };
100 104
101 #endif // GEARS_DATABASE2_STATEMENT_H__ 105 #endif // GEARS_DATABASE2_STATEMENT_H__
LEFTRIGHT

Powered by Google App Engine
This is Rietveld r305