Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1499)

Issue 7060069: Issue 3100: Create \tuplet function and use it everywhere. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dak
Modified:
11 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3100: Create \tuplet function and use it everywhere. This is the big version of issue 3095: it creates convertrules for converting all the \times statements into \tuplet. It also folds immediately preceding \set tupletSpannerDuration into the call. Consists of the following patches (latest to first): Run scripts/auxiliar/update-with-convert-ly.sh define-music-display-methods.scm: use \tuplet rather than \times for TimeScaledMusic convertrules.py: substitute \times with \tuplet where appropriate Create a \tuplet function to complement \times and tupletSpannerDuration Here is its DOC string: Scale the given @var{music} to tuplets. @var{ratio} is a fraction that specifies how many notes are played in place of the nominal value: it will be @samp{3/2} for triplets, namely three notes being played in place of two. If the optional @var{duration} is specified, it is used for initializing @code{tupletSpannerDuration}. For example, @example \tuplet 3/2 4 { c8 c c c c c } @end example will result in two groups of three tuplets, each group lasting for a quarter note. The value of @code{tupletSpannerDuration} is retained as default if it is set in this manner. Clearing it can be achieved by specifying @samp{1*0} as @var{duration}.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+846 lines, -785 lines) Patch
M Documentation/cs/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/cs/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/cs/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/cs/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/essay/engraving.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/de/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/de/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/de/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/de/notation/ancient.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/notation/cheatsheet.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/notation/fretted-strings.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/repeats.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/rhythms.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/de/notation/spacing.itely View 11 chunks +15 lines, -15 lines 0 comments Download
M Documentation/de/notation/vocal.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/essay/engraving.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/es/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/es/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/es/notation/ancient.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/notation/cheatsheet.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/notation/fretted-strings.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/repeats.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/es/notation/spacing.itely View 11 chunks +15 lines, -15 lines 0 comments Download
M Documentation/es/notation/vocal.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/essay/engraving.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/essay/engraving.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/fr/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/fr/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/fr/notation/ancient.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/notation/cheatsheet.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/notation/fretted-strings.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/repeats.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/fr/notation/spacing.itely View 11 chunks +15 lines, -15 lines 0 comments Download
M Documentation/fr/notation/vocal.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/hu/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/hu/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/hu/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/it/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/it/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/it/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/it/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/ja/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/ja/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/ja/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/ja/notation/cheatsheet.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/ja/notation/fretted-strings.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/repeats.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/rhythms.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/ja/notation/spacing.itely View 11 chunks +15 lines, -15 lines 0 comments Download
M Documentation/ja/notation/vocal.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/ly-examples/aucun-snippet.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/ly-examples/cary.ly View 19 chunks +29 lines, -29 lines 0 comments Download
M Documentation/ly-examples/granados.ly View 3 chunks +5 lines, -5 lines 0 comments Download
M Documentation/nl/learning/common-notation.itely View 3 chunks +6 lines, -6 lines 0 comments Download
M Documentation/nl/learning/fundamental.itely View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/nl/learning/tweaks.itely View 3 chunks +9 lines, -9 lines 0 comments Download
M Documentation/notation/ancient.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/notation/cheatsheet.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/repeats.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/rhythms.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/notation/spacing.itely View 11 chunks +15 lines, -15 lines 0 comments Download
M Documentation/notation/vocal.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/adding-beams,-slurs,-ties-etc.-when-using-tuplet-and-non-tuplet-rhythms.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/snippets/changing-the-tuplet-number.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/snippets/controlling-tuplet-bracket-visibility.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/snippets/creating-a-sequence-of-notes-on-various-pitches.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/entering-several-tuplets-using-only-one--times-command.ly View 2 chunks +2 lines, -3 lines 0 comments Download
M Documentation/snippets/flamenco-notation.ly View 6 chunks +10 lines, -10 lines 0 comments Download
M Documentation/snippets/fretted-headword.ly View 3 chunks +17 lines, -17 lines 0 comments Download
M Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/modifying-tuplet-bracket-length.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/new/creating-a-sequence-of-notes-on-various-pitches.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/fretted-headword.ly View 3 chunks +17 lines, -17 lines 0 comments Download
M Documentation/snippets/non-default-tuplet-numbers.ly View 2 chunks +8 lines, -8 lines 0 comments Download
M Documentation/snippets/permitting-line-breaks-within-beamed-tuplets.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly View 3 chunks +7 lines, -7 lines 0 comments Download
M Documentation/snippets/printing-music-with-different-time-signatures.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/proportional-strict-notespacing.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/screech-and-boink.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/unfretted-headword.ly View 3 chunks +11 lines, -11 lines 0 comments Download
M Documentation/snippets/vertically-aligning-ossias-and-lyrics.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/usage/lilypond-book.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M input/regression/alignment-order.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/auto-beam-triplet.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/auto-beam-tuplets.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/autobeam-tuplet-recheck.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/backend-excercise.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/beam-extreme.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/beam-slope-stemlet.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/beam-subdivide-tuplets.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/beaming.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/beaming-tuplet-regular.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/beamlet-test.ly View 2 chunks +9 lines, -9 lines 0 comments Download
M input/regression/breathing-sign-ancient.ly View 5 chunks +5 lines, -5 lines 0 comments Download
M input/regression/chord-repetition-times.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/completion-heads-tuplets.ly View 2 chunks +2 lines, -3 lines 0 comments Download
M input/regression/completion-heads-unit.ly View 2 chunks +2 lines, -3 lines 0 comments Download
M input/regression/display-lily-tests.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/dot-column-engraver.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/grace.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/lyric-combine.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/lyric-combine-switch-voice.ly View 2 chunks +2 lines, -2 lines 0 comments Download
A input/regression/markup-rest.ly View 0 chunks +-1 lines, --1 lines 0 comments Download
A input/regression/markup-rest-styles.ly View 0 chunks +-1 lines, --1 lines 0 comments Download
M input/regression/markup-score.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/metronome-mark-broken-bound.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/midi-tuplets.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/mozart-hrn3-allegro.ily View 2 chunks +14 lines, -14 lines 0 comments Download
M input/regression/part-combine-tuplet-end.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/part-combine-tuplet-single.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/phrasing-slur-tuplet.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/quote-tuplet.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/quote-tuplet-end.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/repeat-slash-mixed.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/skiptypesetting-tuplet.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/slur-shift-region.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/slur-tuplet.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-reordering.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-reordering2.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-loose-polyphony.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-multi-tuplet.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/spacing-proportional.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-strict-notespacing.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-uniform-stretching.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spanner-break-overshoot.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/staff-mixed-size.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tablature-full-notation.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-beam.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/tuplet-bracket-avoid-fingering.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-bracket-avoid-scripts.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-bracket-avoid-string-number.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-bracket-cross-staff.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/tuplet-bracket-direction.ly View 2 chunks +10 lines, -10 lines 0 comments Download
M input/regression/tuplet-bracket-outside-staff-priority.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/tuplet-bracket-vertical-skylines.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-bracket-visibility.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/tuplet-broken.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-full-length.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/tuplet-full-length-extent.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/tuplet-full-length-note.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/tuplet-gap.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-nest.ly View 3 chunks +15 lines, -15 lines 0 comments Download
M input/regression/tuplet-nest-beam.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/tuplet-nest-broken.ly View 2 chunks +12 lines, -12 lines 0 comments Download
M input/regression/tuplet-no-stems.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-number-outside-staff-positioning.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-number-outside-staff-priority.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/tuplet-number-slur-script.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-properties.ly View 2 chunks +11 lines, -11 lines 0 comments Download
M input/regression/tuplet-rest.ly View 2 chunks +9 lines, -9 lines 0 comments Download
M input/regression/tuplet-single-note.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-slope.ly View 1 chunk +8 lines, -8 lines 0 comments Download
M input/regression/tuplet-staffline-collision.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/tuplet-subdivision.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tuplet-text-different-numbers.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/tuplet-text-fraction-with-notes.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/tuplet-text-note-appended.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/tuplets.ly View 2 chunks +6 lines, -6 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +35 lines, -0 lines 0 comments Download
M python/convertrules.py View 1 chunk +29 lines, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b