Simplify several library functions.

Simplify several library functions.

Most of those do not even seem to be used.  Maybe one should instead
remove them instead of having to maintain bit-rot prone stuff.

Simplify hash-table->alist, alist->hash-table, functional-or, functional-and, list-element-index


Simplify first-member and first-assoc

[lemzwerg, 2012-12-27 19:07:15]

Everything looks very nice!  I just wonder how it comes that those
simplifications haven't been done from the very beginning: Is it possible that
functions like `any' or `every' are new in Scheme?

[thomasmorley65, 2012-12-28 15:09:24]

LGTM

Two questions:
a) Where is `identity´ defined? I can't find it, neither in LilyPond nor in the
guile-manual.
b) Why are the definitions in lily-library.scm not all (or nearly all) defined
public?
Some examples:
  split-list
  other-axis
  index-cell
  sign

I see no reason _not_ to make them public.

[dak, 2012-12-28 15:48:56]

On 2012/12/28 15:09:24, thomasmorley65 wrote:
> LGTM
> 
> Two questions:
> a) Where is `identity´ defined? I can't find it, neither in LilyPond nor in
the
> guile-manual.

Huh.  The Guile2 manual shows its definition.  It's a common function and is
equivalent to (lambda (x) x).
I had not been aware that its documentation is deficient in Guile1.

> b) Why are the definitions in lily-library.scm not all (or nearly all) defined
> public?
> Some examples:
>   split-list
>   other-axis
>   index-cell
>   sign
> 
> I see no reason _not_ to make them public.

Actually, that would be the perfect reason to throw them out when they are not
being used in our current code base.  Apart from "other-axis", they are not
really specific to LilyPond and don't offer significant advantages over the
standard Guile libraries.