Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(995)

Issue 7017044: Issue 3049: Parser outputs Lyric events for illegal note names (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dak
Modified:
11 years, 4 months ago
Reviewers:
benko.pal, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3049: Parser outputs Lyric events for illegal note names Well, after this patch this is what we still do (using void-music with duration and post events seems even worse of a followup reaction, silently dropping duration and post events not much better). But additionally, an error is flagged. The complaint is "have to be in Lyric mode for lyrics" which is accurate since in Lyric mode arbitrary strings and markups may be accepted. At the point the error is flagged, we don't necessarily have encountered an unquoted string, so "bad note name" might be even more misleading. Before this issue originated, the parser likely bombed out with "Unexpected STRING", and frankly that's not really better than "have to be in Lyric mode".

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M lily/parser.yy View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM.
11 years, 4 months ago (2012-12-26 22:04:04 UTC) #1
benko.pal
11 years, 4 months ago (2012-12-27 10:24:48 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b