Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4076)

Issue 7016046: Rewrite of Midi.c in Python (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by pkx166h
Modified:
10 years, 2 months ago
Reviewers:
stefaan.himpe
CC:
lilypond-devel_gnu.org, benrg
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Rewrite of Midi.c in Python I rewrote midi.c in Python and tested it on the largest midi file in IMSLP [1]. On my laptop it takes about 200 ms instead of 50 ms to load the file, but that's a small fraction of midi2ly's four-second runtime, and there are a lot of optimizations that can be done in midi2ly itself. (For example, memoizing the creation of Duration objects saves about 500 ms.) I think getting rid of the sole occupant of usr/lib/lilypond/current/python is worth it.

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4
pkx166h
Actually, I didn't rewrite it - as the comment above suggests - this was from ...
11 years, 4 months ago (2012-12-26 21:08:29 UTC) #1
benko.pal
SGTM python/midi.c should be removed (this may involve some make changes) midi files are seen ...
11 years, 4 months ago (2012-12-27 10:11:52 UTC) #2
pkx166h
Ben, Do you have any newer update to the patch based on the comments? I ...
11 years, 3 months ago (2013-01-03 23:34:24 UTC) #3
stefaan.himpe
11 years, 3 months ago (2013-01-04 19:28:35 UTC) #4
Issue with the python midi implementation.

https://codereview.appspot.com/7016046/diff/1/scripts/midi.py
File scripts/midi.py (right):

https://codereview.appspot.com/7016046/diff/1/scripts/midi.py#newcode69
scripts/midi.py:69: (0x07, "CUE_POINT"),
Missing support for meta event 0x08? ("PROGRAM CHANGE") 
This meta event e.g. appears inside musescore generated midi files.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b