Issue 6972044: Better alignment of MetronomeMark to MultiMeasureRest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6972044: Better alignment of MetronomeMark to MultiMeasureRest

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by MikeSol

Modified:
11 years, 4 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Better alignment of MetronomeMark to MultiMeasureRest

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
	M	lily/break-alignment-interface.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download
	M	lily/metronome-engraver.cc	View		7 chunks	+19 lines, -2 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

See https://codereview.appspot.com/1579041#msg3 I'm not sure Neil is correct in his comment, but it would be ...

11 years, 4 months ago (2012-12-20 02:40:11 UTC) #1

MikeSol

11 years, 4 months ago (2012-12-20 11:53:17 UTC) #2

You're right...it was mostly out of laziness and desperation that I did the
quick fix...it worked for a piece I was typesetting.  I have a long plane ride
on the 28th to fix this correctly.

https://codereview.appspot.com/6972044/diff/1/lily/metronome-engraver.cc
File lily/metronome-engraver.cc (right):

https://codereview.appspot.com/6972044/diff/1/lily/metronome-engraver.cc#newc...
lily/metronome-engraver.cc:134: has_note_column_ = true;
On 2012/12/20 02:40:11, Keith wrote:
> Why not just
> \override Score.MetronomeMark #'non-break-align-symbols =
> #'(note-column-interface   multi-measure-rest-interface)

Good call...will do.

Expand All Messages | Collapse All Messages