Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 6944061: Tablature: ignore minimumStretch to/from fret zero (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Keith
Modified:
11 years, 2 months ago
Reviewers:
Graham Percival, marc, carl.d.sorensen, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Tablature: ignore minimumStretch to/from fret zero

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M scm/translation-functions.scm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4
Graham Percival
Not really about this patch, but what happened to the plans for running scripts/auxiliar/fixscm.sh ? ...
11 years, 4 months ago (2012-12-21 07:01:20 UTC) #1
marc
Am 21.12.2012 08:01, schrieb graham@percival-music.ca: > Not really about this patch, but what happened to ...
11 years, 4 months ago (2012-12-21 07:55:18 UTC) #2
Carl
I think the whole issue on this "bug" is incorrect. The problem we have is ...
11 years, 4 months ago (2012-12-23 14:24:31 UTC) #3
dak
11 years, 4 months ago (2012-12-23 14:29:29 UTC) #4
On 2012/12/23 14:24:31, Carl wrote:
> I think the whole issue on this "bug" is incorrect.
> 
> The problem we have is that by using restrain open strings, we are telling
> lilypond "Don't use open strings".  Then by setting minimum-fret to 0, we are
> saying "Do use open strings."  How can we decide what behavior lilypond should
> have when the user is inconsistent in their request?
> 
> I believe the original code is correct -- if restrain-open-strings is true, a
> zero fret should not be allowed.  That's what restrainOpenStrings means.

No, it isn't.  Then it would be "forbidOpenStrings".  Please see the original
discussion.  Open strings are merely restrained to the same level as normal
frets are.  In particular, they obey minimumFret
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b