Doc: NR typo for Midi Instuments used in example

Doc: NR typo for Midi Instuments used in example

Issue 3021

[PhilEHolmes, 2012-12-16 16:33:27]

LGTM

[Trevor Daniels, 2012-12-17 11:27:39]

I'd prefer it if the MIDI instruments in this patch
were not capitalised, in order to be consistent with
the rest of the documentation and in particular with
Appendix A6.  I've no objection in principle to
capitalising the names, but it should be done
consistently throughout the documentation as a
separate patch.

Otherwise LGTM

Trevor

[email_philholmes.net, 2012-12-17 17:21:39]

----- Original Message ----- 
From: <tdanielsmusic@googlemail.com>
To: <pkx166h@gmail.com>; <phileholmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Monday, December 17, 2012 11:27 AM
Subject: Re: Doc: NR typo for Midi Instuments used in example (issue 
6940064)


> I'd prefer it if the MIDI instruments in this patch
> were not capitalised, in order to be consistent with
> the rest of the documentation and in particular with
> Appendix A6.  I've no objection in principle to
> capitalising the names, but it should be done
> consistently throughout the documentation as a
> separate patch.
>
> Otherwise LGTM
>
> Trevor
>
>
> https://codereview.appspot.com/6940064/

I definitely think they should all be capitalised.  See, for example, 
http://www.midi.org/techspecs/gm1sound.php

--
Phil Holmes 

[dak, 2012-12-17 17:38:46]

On 2012/12/17 17:21:39, email_philholmes.net wrote:
> ----- Original Message ----- 
> From: <mailto:tdanielsmusic@googlemail.com>
> To: <pkx166h@gmail.com>; <mailto:phileholmes@googlemail.com>
> Cc: <lilypond-devel@gnu.org>; <mailto:reply@codereview-hr.appspotmail.com>
> Sent: Monday, December 17, 2012 11:27 AM
> Subject: Re: Doc: NR typo for Midi Instuments used in example (issue 
> 6940064)
> 
> 
> > I'd prefer it if the MIDI instruments in this patch
> > were not capitalised, in order to be consistent with
> > the rest of the documentation and in particular with
> > Appendix A6.  I've no objection in principle to
> > capitalising the names, but it should be done
> > consistently throughout the documentation as a
> > separate patch.
> >
> > Otherwise LGTM
> >
> > Trevor
> >
> >
> > https://codereview.appspot.com/6940064/
> 
> I definitely think they should all be capitalised.  See, for example, 
> http://www.midi.org/techspecs/gm1sound.php

It is not a matter of preference.  The definitions in scm/midi.scm
(instrument-names-alist) are lowercase, and LilyPond uses assoc-get in
midi-program for looking them up, which is case-sensitive.

The capitalized versions just won't work for that reason.

[Trevor Daniels, 2012-12-17 19:44:18]

On 2012/12/17 17:38:46, dak wrote:
> 
> The capitalized versions just won't work for that reason.

Actually, they do work if capitalised.  I don't know
why or how - I just do the experiment ;)

Trevor

[pkx166h, 2012-12-17 20:04:54]

On 2012/12/17 19:44:18, Trevor Daniels wrote:
> On 2012/12/17 17:38:46, dak wrote:
> > 
> > The capitalized versions just won't work for that reason.
> 
> Actually, they do work if capitalised.  I don't know
> why or how - I just do the experiment ;)
> 
> Trevor

Well I've put them non-capitalized. So at least it is consistent with
http://www.lilypond.org/doc/v2.16/Documentation/notation/midi-instruments

James

[pkx166h, 2012-12-17 20:05:07]

new patch uploaded

[mail_philholmes.net, 2012-12-17 21:01:29]

----- Original Message ----- 
From: <dak@gnu.org>
To: <pkx166h@gmail.com>; <phileholmes@googlemail.com>; 
<tdanielsmusic@googlemail.com>; <email@philholmes.net>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Monday, December 17, 2012 5:38 PM
Subject: Re: Doc: NR typo for Midi Instuments used in example (issue 
6940064)


> On 2012/12/17 17:21:39, email_philholmes.net wrote:
>> ----- Original Message -----
>> From: <mailto:tdanielsmusic@googlemail.com>
>> To: <pkx166h@gmail.com>; <mailto:phileholmes@googlemail.com>
>> Cc: <lilypond-devel@gnu.org>;
> <mailto:reply@codereview-hr.appspotmail.com>
>> Sent: Monday, December 17, 2012 11:27 AM
>> Subject: Re: Doc: NR typo for Midi Instuments used in example (issue
>> 6940064)
>
>
>> > I'd prefer it if the MIDI instruments in this patch
>> > were not capitalised, in order to be consistent with
>> > the rest of the documentation and in particular with
>> > Appendix A6.  I've no objection in principle to
>> > capitalising the names, but it should be done
>> > consistently throughout the documentation as a
>> > separate patch.
>> >
>> > Otherwise LGTM
>> >
>> > Trevor
>> >
>> >
>> > https://codereview.appspot.com/6940064/
>
>> I definitely think they should all be capitalised.  See, for example,
>> http://www.midi.org/techspecs/gm1sound.php
>
> It is not a matter of preference.  The definitions in scm/midi.scm
> (instrument-names-alist) are lowercase, and LilyPond uses assoc-get in
> midi-program for looking them up, which is case-sensitive.
>
> The capitalized versions just won't work for that reason.
>
> https://codereview.appspot.com/6940064/


I hear what Trevor says (that they do work capitalised) but if we have them 
non-capitalised in our code, that also should be changed, since it doesn't 
follow the standard.

--
Phil Holmes 

[Trevor Daniels, 2012-12-17 23:47:37]

On 2012/12/17 21:01:29, mail_philholmes.net wrote:

> I hear what Trevor says (that they do work capitalised) but if we have them 
> non-capitalised in our code, that also should be changed, since it doesn't 
> follow the standard.

Presumably somewhere the entered name is lower-cased,
so the scm file should not be changed.  Either way,
this needs a new tracker if you want to pursue it.

Trevor

[Trevor Daniels, 2012-12-17 23:48:11]

LGTM

[Graham Percival, 2012-12-21 06:55:17]

LGTM

[pkx166h, 2012-12-25 05:11:49]

author James Lowe <pkx166h@gmail.com>
 Sun, 16 Dec 2012 14:02:19 +0000 (14:02 +0000)
committerJames Lowe <pkx166h@gmail.com>
 Tue, 25 Dec 2012 05:09:05 +0000 (05:09 +0000)
commite854a7373fa1b64b795c58c6fa11345c3e23ef7b