Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 6938050: Adding baseline for Android path renderer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by JimVV
Modified:
11 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This adds the original path renderer files and some support files from Android. Renamed PathRenderer.{cpp,h} to AndroidPathRenderer.{cpp,h} to avoid name collisions. Note: Android open source uses the Apache license, and Skia uses a different license. I'm not sure how to resolve that.

Patch Set 1 #

Patch Set 2 : Changed Apache license to BSD-style license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+926 lines, -0 lines) Patch
A experimental/AndroidPathRenderer/AndroidPathRenderer.h View 1 1 chunk +95 lines, -0 lines 0 comments Download
A experimental/AndroidPathRenderer/AndroidPathRenderer.cpp View 1 1 chunk +712 lines, -0 lines 0 comments Download
A experimental/AndroidPathRenderer/Vertex.h View 1 1 chunk +84 lines, -0 lines 0 comments Download
A experimental/AndroidPathRenderer/cutils/compiler.h View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7
JimVV
11 years, 10 months ago (2012-12-13 18:43:06 UTC) #1
robertphillips
Mike - any thoughts about the license? Otherwise, LGTM.
11 years, 10 months ago (2012-12-13 18:58:39 UTC) #2
reed1
skia is a mix of Apache and BSD, so no problem. lgtm
11 years, 10 months ago (2012-12-13 18:59:30 UTC) #3
reed1
Actually, I take that back. We did a sweeping conversion over to BSD. Jim, any ...
11 years, 10 months ago (2012-12-13 19:00:33 UTC) #4
JimVV
Updated the headers to use BSD-style license.
11 years, 10 months ago (2012-12-13 19:14:50 UTC) #5
robertphillips
LGTM
11 years, 10 months ago (2012-12-13 19:46:47 UTC) #6
JimVV
11 years, 10 months ago (2012-12-13 19:57:11 UTC) #7
Message was sent while issue was closed.
Committed as r6789.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b