Please review. I didn't touch the translations. Correct? git grep "#'#" returns one file I ...
12 years, 3 months ago
(2012-12-11 00:31:04 UTC)
#1
Please review.
I didn't touch the translations. Correct?
git grep "#'#"
returns one file I don't know what to do with:
Binary file Documentation/pictures/baer-sarabande-original.jpg matches
On 2012/12/11 00:31:04, thomasmorley65 wrote: > Please review. > > > I didn't touch the ...
12 years, 3 months ago
(2012-12-11 05:42:07 UTC)
#2
On 2012/12/11 00:31:04, thomasmorley65 wrote:
> Please review.
>
>
> I didn't touch the translations. Correct?
>
> git grep "#'#"
> returns one file I don't know what to do with:
> Binary file Documentation/pictures/baer-sarabande-original.jpg matches
Binaries are prone to matching very short strings randomly, signifying nothing.
No need to worry.
LGTM
LGTM.
I suppose that one of David's changes made this patch possible; if you know
which one it is it would be good to note this (but if you don't know i think
it's not worth the trouble to search).
On 2013/03/27 21:53:39, janek wrote:
> LGTM.
>
> I suppose that one of David's changes made this patch possible; if you know
> which one it is it would be good to note this (but if you don't know i think
> it's not worth the trouble to search).
No thanks to me: #(1 2 3) always has been the Scheme syntax for literal vectors
without the need of additional quoting. That's exactly why I considered the
extra quoting in our code base irritating. Beginners will construct their own
theories of why it is necessary and what it is supposed to mean, and that is not
helping their understanding.
Issue 6923043: Removes '-signs from vectors
(Closed)
Created 12 years, 3 months ago by thomasmorley65
Modified 12 years ago
Reviewers: dak, Trevor Daniels, Graham Percival, janek
Base URL:
Comments: 0