LGTM On Wed, Nov 14, 2012 at 1:02 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
11 years, 4 months ago
(2012-11-14 21:08:43 UTC)
#2
LGTM
On Wed, Nov 14, 2012 at 1:02 PM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> sudo.bash: diagnose when the go tool is not in $PATH
> Fixes issue 4386.
>
> Please review this at http://codereview.appspot.com/6854050/
>
> Affected files:
> M src/sudo.bash
>
>
> Index: src/sudo.bash
> ===================================================================
> --- a/src/sudo.bash
> +++ b/src/sudo.bash
> @@ -12,6 +12,12 @@
> exit 0
> esac
>
> +# Check that the go command exists
> +if ! go help >/dev/null 2>&1; then
> + echo "The go command is not in your PATH." >&2
> + exit 2
> +fi
> +
> eval $(go env)
> if ! [ -x $GOTOOLDIR/cov -a -x $GOTOOLDIR/prof ]; then
> echo "You don't need to run sudo.bash." >&2
>
>
Issue 6854050: code review 6854050: sudo.bash: diagnose when the go tool is not in $PATH
(Closed)
Created 11 years, 4 months ago by r
Modified 11 years, 4 months ago
Reviewers:
Base URL:
Comments: 0