this is broken http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py File MoinMoin/items/content.py (right): http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod... MoinMoin/items/content.py:413: def put_member(self, tf, name, content, content_length, expected_members): this can only work, if we receive all components in a single post. http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod... MoinMoin/items/content.py:1161: cache_key(usage='TarContainer', name=self.name)) this looks insane http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod... MoinMoin/items/content.py:1162: tarbuffer = StringIO(temp_fname) this even more
On 2012/11/18 18:17:46, Thomas.J.Waldmann wrote: > this is broken I know that it is doing so only with svg-edit. I played a little bit with StringIO and it seems to me we can't use append mode for tar files with it. > > http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py > File MoinMoin/items/content.py (right): > > http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod... > MoinMoin/items/content.py:413: def put_member(self, tf, name, content, > content_length, expected_members): > this can only work, if we receive all components in a single post. > > http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod... > MoinMoin/items/content.py:1161: cache_key(usage='TarContainer', name=self.name)) > this looks insane > > http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod... > MoinMoin/items/content.py:1162: tarbuffer = StringIO(temp_fname) > this even more