Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(120)

Issue 6851096: code review 6851096: net: check read and write deadlines before doing syscalls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by bradfitz
Modified:
11 years, 4 months ago
Reviewers:
rsc
CC:
golang-dev, brainman, dfc, mikio
Visibility:
Public.

Description

net: check read and write deadlines before doing syscalls Otherwise a fast sender or receiver can make sockets always readable or writable, preventing deadline checks from ever occuring. Update issue 4191 (fixes it with other CL, coming separately) Fixes issue 4403

Patch Set 1 #

Patch Set 2 : diff -r b96491ad23fd https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r b96491ad23fd https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 4 : diff -r 74b1ad92a812 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 40ffcafb291e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -0 lines) Patch
M src/pkg/net/fd_unix.go View 1 2 3 6 chunks +36 lines, -0 lines 0 comments Download
M src/pkg/net/timeout_test.go View 1 2 3 4 2 chunks +201 lines, -0 lines 0 comments Download

Messages

Total messages: 14
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 4 months ago (2012-11-22 19:01:37 UTC) #1
bradfitz
Seems to work on OS X. Must be an epoll pollster bug. On Thu, Nov ...
11 years, 4 months ago (2012-11-22 21:08:06 UTC) #2
bradfitz
.... but still very sporadic timing on GOMAXPROCS=1 on OS X. GOMAXPROCS > 1 is ...
11 years, 4 months ago (2012-11-22 21:08:48 UTC) #3
brainman
PASSes on windows, but only if http://codereview.appspot.com/6851098 applied. Thank you. You, probably, want to clean ...
11 years, 4 months ago (2012-11-23 01:43:04 UTC) #4
dfc
I think their is a bug in netFD.Read (and others) where the timeout logic is ...
11 years, 4 months ago (2012-11-23 13:08:06 UTC) #5
mikio
why not in timeout_test.go?
11 years, 4 months ago (2012-11-23 14:45:28 UTC) #6
bradfitz
I can move it. It started as a different test and morphed into that test. ...
11 years, 4 months ago (2012-11-23 19:16:06 UTC) #7
bradfitz
Hello golang-dev@googlegroups.com, alex.brainman@gmail.com, dave@cheney.net, mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 4 months ago (2012-11-24 01:03:54 UTC) #8
dfc
Thanks Brad, what an epic! I think same fix needs to be made to the ...
11 years, 4 months ago (2012-11-24 05:06:26 UTC) #9
bradfitz
Hello golang-dev@googlegroups.com, alex.brainman@gmail.com, dave@cheney.net, mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 4 months ago (2012-11-24 05:32:18 UTC) #10
bradfitz
On Fri, Nov 23, 2012 at 9:06 PM, <dave@cheney.net> wrote: > Thanks Brad, what an ...
11 years, 4 months ago (2012-11-24 05:36:07 UTC) #11
dfc
LGTM, with minor comments. Thank you for fixing this Brad. I'm really happy that there ...
11 years, 4 months ago (2012-11-24 05:57:51 UTC) #12
bradfitz
*** Submitted as http://code.google.com/p/go/source/detail?r=ffd1e075c260 *** net: check read and write deadlines before doing syscalls Otherwise ...
11 years, 4 months ago (2012-11-24 06:15:31 UTC) #13
rsc
11 years, 4 months ago (2012-11-26 19:22:56 UTC) #14
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b