code review 6847086: go/printer: Permit declaration and statement lists as input.

go/printer: Permit declaration and statement lists as input.

Also: Can set base indentation in printer.Config: all code
is going to be indented by at least that amount (except for
raw string literals spanning multiple lines, since their
values must not change).

[gri, 2012-11-21 22:47:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-11-26 16:45:36]

Tests?

[gri, 2012-11-26 19:36:17]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-11-26 21:03:28]

LGTM

[gri, 2012-11-26 21:14:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=c2c17abf9eb0 ***

go/printer: Permit declaration and statement lists as input.

Also: Can set base indentation in printer.Config: all code
is going to be indented by at least that amount (except for
raw string literals spanning multiple lines, since their
values must not change).

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6847086

[dfc, 2012-11-26 21:42:03]

Weird, this is failing, but only on 386 (possibly all 32 bit builders)

On Tue, Nov 27, 2012 at 8:14 AM,  <gri@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=c2c17abf9eb0 ***
>
>
> go/printer: Permit declaration and statement lists as input.
>
> Also: Can set base indentation in printer.Config: all code
> is going to be indented by at least that amount (except for
> raw string literals spanning multiple lines, since their
> values must not change).
>
> R=golang-dev, rsc
> CC=golang-dev
> http://codereview.appspot.com/6847086
>
>
> http://codereview.appspot.com/6847086/

[remyoudompheng, 2012-11-26 21:48:28]

On 2012/11/26 Dave Cheney <dave@cheney.net> wrote:
> Weird, this is failing, but only on 386 (possibly all 32 bit builders)

I confirm the issue on linux/386 and linux/arm.

[gri, 2012-11-26 22:15:20]

I have a fix for this - coming shortly.
Sorry about this.
- gri

On Mon, Nov 26, 2012 at 1:48 PM, Rémy Oudompheng
<remyoudompheng@gmail.com> wrote:
> On 2012/11/26 Dave Cheney <dave@cheney.net> wrote:
>> Weird, this is failing, but only on 386 (possibly all 32 bit builders)
>
> I confirm the issue on linux/386 and linux/arm.

[remyoudompheng, 2012-11-26 22:17:43]

Indeed, we have an overflow happening at:

if headerSize+p.bodySize(b, maxSize) <= maxSize

when both sides of the "+" are infinity=1<<30