Issue 6847080: quickstart-PR review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847080: quickstart-PR review

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by holger krekel

Modified:
8 years, 4 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

quickstart-PR review

Patch Set 1 #

Total comments: 4

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+319 lines, -1 line)			Patch
M	setup.py	View	1 chunk	+1 line, -1 line	1 comment	Download
A	tests/test_quickstart.py	View	1 chunk	+98 lines, -0 lines	0 comments	Download
M	tox/__init__.py	View	1 chunk	+1 line, -0 lines	1 comment	Download
A	tox/_quickstart.py	View	1 chunk	+219 lines, -0 lines	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

holger krekel

11 years, 5 months ago (2012-11-21 07:55:42 UTC) #1

http://codereview.appspot.com/6847080/diff/1/setup.py
File setup.py (left):

http://codereview.appspot.com/6847080/diff/1/setup.py#oldcode59
setup.py:59: # we use a public tox version to test, see tox.ini's testenv
this can directly reference tox._quickstart:main so that tox/__init__ doesn't
need to include it.

http://codereview.appspot.com/6847080/diff/1/tox/__init__.py
File tox/__init__.py (right):

http://codereview.appspot.com/6847080/diff/1/tox/__init__.py#newcode24
tox/__init__.py:24: from tox._quickstart import main as quickstart
this import is not needed and slows down the general tox importing

http://codereview.appspot.com/6847080/diff/1/tox/_quickstart.py
File tox/_quickstart.py (right):

http://codereview.appspot.com/6847080/diff/1/tox/_quickstart.py#newcode162
tox/_quickstart.py:162: - python setup.py test
this desparately needs a py.test choice! :)

http://codereview.appspot.com/6847080/diff/1/tox/_quickstart.py#newcode172
tox/_quickstart.py:172: 
let's default the dependencies to nose for "nosetests", "pytest" for "py.test"
and "twisted" for "trial".

Expand All Messages | Collapse All Messages