code review 6847050: run.bash: unset GOMAXPROCS before ../test

run.{bash,bat,rc}: unset GOMAXPROCS before ../test

test/run.go already executes tests in parallel where
possible. An unknown GOMAXPROCS value during the tests
is known to cause failures with tests that measure
allocations.

ref: https://groups.google.com/d/topic/golang-nuts/tgMhFJ3F5WY/discussion

[dfc, 2012-11-14 10:18:58]

Hello fullung@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[albert.strasheim, 2012-11-14 10:24:12]

LGTM

This change makes this kind of complete test easier:

./make.bash
for i in `seq 1 5`; do
export GOMAXPROCS=$[ 1 + $[ RANDOM % 128 ]]
./run.bash --no-rebuild
done

Cheers

Albert

[albert.strasheim, 2012-11-14 10:24:12]

LGTM

This change makes this kind of complete test easier:

./make.bash
for i in `seq 1 5`; do
export GOMAXPROCS=$[ 1 + $[ RANDOM % 128 ]]
./run.bash --no-rebuild
done

Cheers

Albert

[minux1, 2012-11-14 10:25:24]

please also change run.bat and run.rc.

[dfc, 2012-11-14 10:25:53]

Will do. Sorry, I always forget about those crazy kids.

On Wed, Nov 14, 2012 at 9:25 PM, minux <minux.ma@gmail.com> wrote:
> please also change run.bat and run.rc.

[dfc, 2012-11-14 10:30:58]

Hello fullung@gmail.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-11-14 10:46:00]

LGTM.

https://codereview.appspot.com/6847050/diff/7001/src/run.rc
File src/run.rc (right):

https://codereview.appspot.com/6847050/diff/7001/src/run.rc#newcode47
src/run.rc:47: time go run run.go
GOMAXPROCS='' time go run run.go

[r, 2012-11-14 14:33:08]

LGTM

https://codereview.appspot.com/6847050/diff/7001/src/run.bash
File src/run.bash (right):

https://codereview.appspot.com/6847050/diff/7001/src/run.bash#newcode119
src/run.bash:119: time go run run.go
this is fine, but so is
GOMAXPROCS= time go run run.go

[dfc, 2012-11-15 00:23:26]

Thank you for your comments. PTAL

https://codereview.appspot.com/6847050/diff/7001/src/run.bash
File src/run.bash (right):

https://codereview.appspot.com/6847050/diff/7001/src/run.bash#newcode119
src/run.bash:119: time go run run.go
On 2012/11/14 14:33:08, r wrote:
> this is fine, but so is
> GOMAXPROCS= time go run run.go

Done.

https://codereview.appspot.com/6847050/diff/7001/src/run.rc
File src/run.rc (right):

https://codereview.appspot.com/6847050/diff/7001/src/run.rc#newcode47
src/run.rc:47: time go run run.go
On 2012/11/14 10:46:01, minux wrote:
> GOMAXPROCS='' time go run run.go

Done.

[dfc, 2012-11-15 00:41:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=c4cc7dcc49cb ***

run.{bash,bat,rc}: unset GOMAXPROCS before ../test

test/run.go already executes tests in parallel where
possible. An unknown GOMAXPROCS value during the tests
is known to cause failures with tests that measure
allocations.

ref: https://groups.google.com/d/topic/golang-nuts/tgMhFJ3F5WY/discussion

R=fullung, minux.ma, r
CC=golang-dev
http://codereview.appspot.com/6847050