Issue 6846045: code review 6846045: regexp: add simple package-level example

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6846045: code review 6846045: regexp: add simple package-level example (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by adg

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

regexp: add simple package-level example Update issue 4125

Patch Set 2 : diff -r badc904a3473 https://code.google.com/p/go #

Patch Set 3 : diff -r d9896259d8e5 https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	A	src/pkg/regexp/example_test.go	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2012-11-13 11:53:05 UTC) #1

http://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go File src/pkg/regexp/example_test.go (right): http://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go#newcode9 src/pkg/regexp/example_test.go:9: // Compile the expression once, usually at init time. ...

11 years, 5 months ago (2012-11-13 15:26:03 UTC) #2

adg

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 5 months ago (2012-11-13 15:54:46 UTC) #3

adg

https://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go File src/pkg/regexp/example_test.go (right): https://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go#newcode9 src/pkg/regexp/example_test.go:9: // Compile the expression once, usually at init time. ...

11 years, 5 months ago (2012-11-13 15:54:48 UTC) #4

adg

11 years, 5 months ago (2012-11-14 09:43:27 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=cbb5a28097e9 ***

regexp: add simple package-level example

Update issue 4125

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6846045

Expand All Messages | Collapse All Messages