Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Issue 6845058: code review 6845058: cmd/api: speed up API check by 2x, caching parser.Parse... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by bradfitz
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, remyoudompheng, minux1, gri
Visibility:
Public.

Description

cmd/api: speed up API check by 2x, caching parser.ParseFile calls Saves 5 seconds on my machine. If Issue 4380 is fixed this clone can be removed. Update issue 4380

Patch Set 1 #

Patch Set 2 : diff -r a26a8ada8f6e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a26a8ada8f6e https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 440de6b98362 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6d4229bb6307 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -1 line) Patch
A src/cmd/api/clone.go View 1 2 3 1 chunk +251 lines, -0 lines 0 comments Download
M src/cmd/api/goapi.go View 1 2 chunks +16 lines, -1 line 0 comments Download
M src/cmd/api/testdata/src/pkg/p1/p1.go View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 4 months ago (2012-11-17 19:09:47 UTC) #1
remyoudompheng
http://codereview.appspot.com/6845058/diff/5001/src/cmd/api/clone.go File src/cmd/api/clone.go (right): http://codereview.appspot.com/6845058/diff/5001/src/cmd/api/clone.go#newcode26 src/cmd/api/clone.go:26: if i == nil { why not put case ...
11 years, 4 months ago (2012-11-17 19:19:59 UTC) #2
minux1
have you benchmarked this against a generic reflect-based clone? https://codereview.appspot.com/6845058/diff/5001/src/cmd/api/goapi.go File src/cmd/api/goapi.go (right): https://codereview.appspot.com/6845058/diff/5001/src/cmd/api/goapi.go#newcode448 src/cmd/api/goapi.go:448: ...
11 years, 4 months ago (2012-11-17 19:31:36 UTC) #3
bradfitz
On Nov 17, 2012 11:31 AM, <minux.ma@gmail.com> wrote: > > have you benchmarked this against ...
11 years, 4 months ago (2012-11-17 19:56:01 UTC) #4
bradfitz
PTAL https://codereview.appspot.com/6845058/diff/5001/src/cmd/api/clone.go File src/cmd/api/clone.go (right): https://codereview.appspot.com/6845058/diff/5001/src/cmd/api/clone.go#newcode26 src/cmd/api/clone.go:26: if i == nil { On 2012/11/17 19:19:59, ...
11 years, 4 months ago (2012-11-17 22:13:09 UTC) #5
bradfitz
Robert?
11 years, 4 months ago (2012-11-19 19:12:23 UTC) #6
gri
LGTM
11 years, 4 months ago (2012-11-19 21:22:04 UTC) #7
bradfitz
11 years, 4 months ago (2012-11-19 21:50:23 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=a070de932857 ***

cmd/api: speed up API check by 2x, caching parser.ParseFile calls

Saves 5 seconds on my machine. If Issue 4380 is fixed this
clone can be removed.

Update issue 4380

R=golang-dev, remyoudompheng, minux.ma, gri
CC=golang-dev
http://codereview.appspot.com/6845058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b